From: Stephen Hemminger <shemminger@vyatta.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Alex Williamson <alex.williamson@hp.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] virtio_net: add more ethtool information
Date: Thu, 3 Dec 2009 16:33:10 -0800 [thread overview]
Message-ID: <20091203163310.1553689e@nehalam> (raw)
In-Reply-To: <200912041032.23865.rusty@rustcorp.com.au>
On Fri, 4 Dec 2009 10:32:23 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Thu, 3 Dec 2009 05:02:26 pm Stephen Hemminger wrote:
> > It is useful for some tools (as well as bonding, and bridging)
> > for virtio network interface provide more ethtool information.
>
> Hi Stephen,
>
> Can't see any harm. Some minor questions below:
>
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > --- a/drivers/net/virtio_net.c 2009-12-01 14:24:14.766450584 -0800
> > +++ b/drivers/net/virtio_net.c 2009-12-01 16:49:18.295535415 -0800
> > @@ -763,7 +763,36 @@ static void virtnet_vlan_rx_kill_vid(str
> > dev_warn(&dev->dev, "Failed to kill VLAN ID %d.\n", vid);
> > }
> >
> > +static void virtnet_get_drvinfo(struct net_device *dev,
> > + struct ethtool_drvinfo *info)
> > +{
> > + struct virtnet_info *vi = netdev_priv(dev);
> > +
> > + strcpy(info->driver, "virtnet");
> > + strcpy(info->version, "0.1");
> > + strcpy(info->fw_version, "N/A");
> > + strcpy(info->bus_info, dev_driver_string(&vi->vdev->dev));
>
> 0.1 as a version is weird. If we need a number, "0" seems best.
>
> > + cmd->speed = SPEED_1000;
>
> Why 1000? Because it's commong? How about a SPEED_UNLIMITED?
>
Well until the performance is improved, that is about what I see!
prev parent reply other threads:[~2009-12-04 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091203063225.926337440@vyatta.com>
2009-12-03 6:32 ` [PATCH] virtio_net: add more ethtool information Stephen Hemminger
2009-12-04 0:02 ` Rusty Russell
2009-12-04 0:33 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203163310.1553689e@nehalam \
--to=shemminger@vyatta.com \
--cc=alex.williamson@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).