From: Krishna Kumar <krkumar2@in.ibm.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Krishna Kumar <krkumar2@in.ibm.com>
Subject: [PATCH] ipv6: Fix "waiting for %s to become free" hang
Date: Fri, 04 Dec 2009 16:57:34 +0530 [thread overview]
Message-ID: <20091204112734.24535.86096.sendpatchset@localhost.localdomain> (raw)
From: Krishna Kumar <krkumar2@in.ibm.com>
(From code-walkthrough, and untested)
Fix "waiting for %s to become free" hang. dev has an
extra hold (by ip6mr_reg_vif) which was not dropped
before calling unregister_netdevice.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
net/ipv6/ip6mr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -ruNp org/net/ipv6/ip6mr.c new/net/ipv6/ip6mr.c
--- org/net/ipv6/ip6mr.c 2009-12-04 16:08:07.000000000 +0530
+++ new/net/ipv6/ip6mr.c 2009-12-04 16:09:56.000000000 +0530
@@ -648,8 +648,8 @@ static int mif6_add(struct net *net, str
return -ENOBUFS;
err = dev_set_allmulti(dev, 1);
if (err) {
- unregister_netdevice(dev);
dev_put(dev);
+ unregister_netdevice(dev);
return err;
}
break;
next reply other threads:[~2009-12-04 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 11:27 Krishna Kumar [this message]
2009-12-04 11:40 ` [PATCH] ipv6: Fix "waiting for %s to become free" hang Eric Dumazet
2009-12-04 12:15 ` Krishna Kumar2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204112734.24535.86096.sendpatchset@localhost.localdomain \
--to=krkumar2@in.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).