[PATCH] Remove deprecated print_mac to fix warnings

[PATCH] Remove deprecated print_mac to fix warnings

[Andi Kleen]

Remove deprecated and unused print_mac to fix warnings

There seems to be no user in tree of print_mac left. So just remove it.

This eliminates two compiler warnings for every build, because gcc
complains about the deprecated use of the symbol in its EXPORT_SYMBOL.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

---
 include/linux/if_ether.h |    1 -
 net/ethernet/eth.c       |    7 -------
 2 files changed, 8 deletions(-)

Index: linux-2.6.32-ak/include/linux/if_ether.h
===================================================================
--- linux-2.6.32-ak.orig/include/linux/if_ether.h
+++ linux-2.6.32-ak/include/linux/if_ether.h
@@ -139,7 +139,6 @@ extern ssize_t sysfs_format_mac(char *bu
 /*
  *	Display a 6 byte device address (MAC) in a readable format.
  */
-extern char *print_mac(char *buf, const unsigned char *addr) __deprecated;
 #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
 #define MAC_BUF_SIZE	18
 #define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE]
Index: linux-2.6.32-ak/net/ethernet/eth.c
===================================================================
--- linux-2.6.32-ak.orig/net/ethernet/eth.c
+++ linux-2.6.32-ak/net/ethernet/eth.c
@@ -393,10 +393,3 @@ ssize_t sysfs_format_mac(char *buf, cons
 	return ((ssize_t) l);
 }
 EXPORT_SYMBOL(sysfs_format_mac);
-
-char *print_mac(char *buf, const unsigned char *addr)
-{
-	_format_mac_addr(buf, MAC_BUF_SIZE, addr, ETH_ALEN);
-	return buf;
-}
-EXPORT_SYMBOL(print_mac);

Re: [PATCH] Remove deprecated print_mac to fix warnings

[Joe Perches]

On Sun, 2009-12-06 at 15:08 +0100, Andi Kleen wrote:
> Remove deprecated and unused print_mac to fix warnings
[]
> --- linux-2.6.32-ak.orig/include/linux/if_ether.h
> +++ linux-2.6.32-ak/include/linux/if_ether.h
> @@ -139,7 +139,6 @@ extern ssize_t sysfs_format_mac(char *bu
>  /*
>   *	Display a 6 byte device address (MAC) in a readable format.
>   */
> -extern char *print_mac(char *buf, const unsigned char *addr) __deprecated;
>  #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
>  #define MAC_BUF_SIZE	18
>  #define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE]

#define MAC_BUF_SIZE and #define DECLARE_MAC_BUF
should be removed as well.

Re: [PATCH] Remove deprecated print_mac to fix warnings

[David Miller]

From: Andi Kleen <andi@firstfloor.org>
Date: Sun, 6 Dec 2009 15:08:28 +0100

> Remove deprecated and unused print_mac to fix warnings
> 
> There seems to be no user in tree of print_mac left. So just remove it.
> 
> This eliminates two compiler warnings for every build, because gcc
> complains about the deprecated use of the symbol in its EXPORT_SYMBOL.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

davem@sunset:~/src/GIT/net-next-2.6$ git grep print_mac
davem@sunset:~/src/GIT/net-next-2.6$ 

Re: [PATCH] Remove deprecated print_mac to fix warnings

[Andi Kleen]

On Sun, Dec 06, 2009 at 11:17:39AM -0800, David Miller wrote:
> From: Andi Kleen <andi@firstfloor.org>
> Date: Sun, 6 Dec 2009 15:08:28 +0100
> 
> > Remove deprecated and unused print_mac to fix warnings
> > 
> > There seems to be no user in tree of print_mac left. So just remove it.
> > 
> > This eliminates two compiler warnings for every build, because gcc
> > complains about the deprecated use of the symbol in its EXPORT_SYMBOL.
> > 
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> davem@sunset:~/src/GIT/net-next-2.6$ git grep print_mac
> davem@sunset:~/src/GIT/net-next-2.6$ 

Great. I grepped in linux-next, but perhaps I raced with you.

But could that please be fixed in a 2.6.32 stable too? the warnings 
on every build are annoying.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

Re: [PATCH] Remove deprecated print_mac to fix warnings

[David Miller]

From: Andi Kleen <andi@firstfloor.org>
Date: Sun, 6 Dec 2009 20:19:26 +0100

> On Sun, Dec 06, 2009 at 11:17:39AM -0800, David Miller wrote:
>> From: Andi Kleen <andi@firstfloor.org>
>> Date: Sun, 6 Dec 2009 15:08:28 +0100
>> 
>> > Remove deprecated and unused print_mac to fix warnings
>> > 
>> > There seems to be no user in tree of print_mac left. So just remove it.
>> > 
>> > This eliminates two compiler warnings for every build, because gcc
>> > complains about the deprecated use of the symbol in its EXPORT_SYMBOL.
>> > 
>> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>> 
>> davem@sunset:~/src/GIT/net-next-2.6$ git grep print_mac
>> davem@sunset:~/src/GIT/net-next-2.6$ 
> 
> Great. I grepped in linux-next, but perhaps I raced with you.

It's been removed in net-next-2.6 for weeks.

> But could that please be fixed in a 2.6.32 stable too? the warnings 
> on every build are annoying.

Sorry, no.

Re: [PATCH] Remove deprecated print_mac to fix warnings

[Andi Kleen]

> > But could that please be fixed in a 2.6.32 stable too? the warnings 
> > on every build are annoying.
> 
> Sorry, no.

Thanks. I'll remember that on every build.

-Andi