From: Frederic Leroy <fredo@starox.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Damian Lukowski <damian@tvk.rwth-aachen.de>,
Eric Dumazet <eric.dumazet@gmail.com>,
Netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Greg KH <gregkh@suse.de>
Subject: Re: [PATCHv3 1/2] tcp: Stalling connections: Fix timeout calculation routine
Date: Mon, 7 Dec 2009 20:09:04 +0100 [thread overview]
Message-ID: <20091207200904.5f6e145a@houba> (raw)
In-Reply-To: <alpine.DEB.2.00.0912072046500.27565@melkinpaasi.cs.helsinki.fi>
Le Mon, 7 Dec 2009 20:50:11 +0200 (EET),
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> a écrit :
> On Mon, 7 Dec 2009, Damian Lukowski wrote:
>
> > This patch fixes a problem in the TCP connection timeout
> > calculation. Currently, timeout decisions are made on the basis of
> > 6fa12c85031485dff38ce550c24f10da23b0adaa.
> [...]
>> > static inline struct sk_buff *tcp_send_head(struct sock *sk)
>
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
> Also, this should be added:
>
> Reported-by: Frederic Leroy <fredo@starox.org>
>
> ...and I think he has already tested this fix a number of times in
> different forms, so I'd already include his Tested-by: too.
If you need a bad connection to do some test, don't hesitate !
Thank you guys ;)
--
Frédéric Leroy
next prev parent reply other threads:[~2009-12-07 19:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 0:28 [PATCH] tcp: Fix for stalling connections Damian Lukowski
2009-12-07 0:32 ` Damian Lukowski
2009-12-07 6:15 ` Eric Dumazet
2009-12-07 11:17 ` Damian Lukowski
2009-12-07 11:22 ` David Miller
2009-12-07 11:41 ` [PATCHv2 0/2] tcp: Stalling connections Damian Lukowski
2009-12-07 11:41 ` [PATCHv2 1/2] tcp: Stalling connections: Move timeout calculation routine Damian Lukowski
2009-12-07 12:01 ` Frederic Leroy
2009-12-07 16:11 ` Damian Lukowski
2009-12-07 11:41 ` [PATCHv2 2/2] tcp: Stalling connections: Fix " Damian Lukowski
2009-12-07 12:08 ` Ilpo Järvinen
2009-12-07 12:27 ` Damian Lukowski
2009-12-07 12:32 ` Ilpo Järvinen
2009-12-07 16:06 ` [PATCHv3 0/2] tcp: Stalling connections Damian Lukowski
2009-12-07 16:06 ` [PATCHv3 1/2] tcp: Stalling connections: Fix timeout calculation routine Damian Lukowski
2009-12-07 18:50 ` Ilpo Järvinen
2009-12-07 19:09 ` Frederic Leroy [this message]
2009-12-10 13:24 ` TCP not retransmitting Ilpo Järvinen
2009-12-11 12:57 ` Frederic Leroy
2009-12-09 4:53 ` [PATCHv3 1/2] tcp: Stalling connections: Fix timeout calculation routine David Miller
2009-12-07 16:06 ` [PATCHv3 2/2] tcp: Stalling connections: Move " Damian Lukowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207200904.5f6e145a@houba \
--to=fredo@starox.org \
--cc=damian@tvk.rwth-aachen.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).