From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: [patch] net/sctp/sysctl.c: Remove dead strategy handler Date: Tue, 8 Dec 2009 20:52:09 +0100 Message-ID: <20091208195209.GA30947@elte.hu> References: <20091205.193505.193701079.davem@davemloft.net> <20091208194530.GA24530@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller , "Eric W. Biederman" Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:44926 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965919AbZLHTwQ (ORCPT ); Tue, 8 Dec 2009 14:52:16 -0500 Content-Disposition: inline In-Reply-To: <20091208194530.GA24530@elte.hu> Sender: netdev-owner@vger.kernel.org List-ID: * Ingo Molnar wrote: > hi Dave, > > i just switched to today's -git tree and there's this new build failure > on x86: > > net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer > net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function) > > havent looked into it yet - config attached. That's interaction with the strategy handler removal from Eric. I think the patch below will do the trick - the callsites have been updated already to use proc_handler, so ->handler was a dead field. Ingo Signed-off-by: Ingo Molnar diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index 419e1e9..832590b 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -248,7 +248,6 @@ static ctl_table sctp_table[] = { .maxlen = sizeof(int), .mode = 0644, .proc_handler = &proc_dointvec_minmax, - .strategy = &sysctl_intvec, .extra1 = &one, .extra2 = &rwnd_scale_max, },