* [PATCH -next] net: niu uses crc32, so select CRC32
[not found] <20091210175919.340b4c0c.sfr@canb.auug.org.au>
@ 2009-12-10 17:31 ` Randy Dunlap
2009-12-10 21:51 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2009-12-10 17:31 UTC (permalink / raw)
To: Stephen Rothwell, netdev; +Cc: linux-next, LKML, davem
From: Randy Dunlap <randy.dunlap@oracle.com>
niu drivers uses crc32 functions, so it needs to select CRC32.
niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20091210.orig/drivers/net/Kconfig
+++ linux-next-20091210/drivers/net/Kconfig
@@ -2698,6 +2698,7 @@ config NETXEN_NIC
config NIU
tristate "Sun Neptune 10Gbit Ethernet support"
depends on PCI
+ select CRC32
help
This enables support for cards based upon Sun's
Neptune chipset.
---
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: niu uses crc32, so select CRC32
2009-12-10 17:31 ` [PATCH -next] net: niu uses crc32, so select CRC32 Randy Dunlap
@ 2009-12-10 21:51 ` David Miller
2009-12-10 21:59 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-12-10 21:51 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, netdev, linux-next, linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 10 Dec 2009 09:31:03 -0800
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> niu drivers uses crc32 functions, so it needs to select CRC32.
>
> niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied, thanks Randy.
That dependency is quite indirect, it's due to ether_crc_*().
I bet a quick grep for that will find several other drivers
missing this Kconfig bit.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: niu uses crc32, so select CRC32
2009-12-10 21:51 ` David Miller
@ 2009-12-10 21:59 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2009-12-10 21:59 UTC (permalink / raw)
To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel
On Thu, 10 Dec 2009 13:51:38 -0800 (PST) David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Thu, 10 Dec 2009 09:31:03 -0800
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > niu drivers uses crc32 functions, so it needs to select CRC32.
> >
> > niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Applied, thanks Randy.
>
> That dependency is quite indirect, it's due to ether_crc_*().
> I bet a quick grep for that will find several other drivers
> missing this Kconfig bit.
Yes, I've noticed that also...
---
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-10 21:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20091210175919.340b4c0c.sfr@canb.auug.org.au>
2009-12-10 17:31 ` [PATCH -next] net: niu uses crc32, so select CRC32 Randy Dunlap
2009-12-10 21:51 ` David Miller
2009-12-10 21:59 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).