From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
mallikarjuna.chilakala@intel.com,
peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-2.6 PATCH 3/3] Fix 82598 premature copper PHY link indicatation
Date: Sun, 13 Dec 2009 19:18:58 -0800 (PST) [thread overview]
Message-ID: <20091213.191858.71104129.davem@davemloft.net> (raw)
In-Reply-To: <20091212075200.10952.13217.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 11 Dec 2009 23:52:01 -0800
> + for (timeout = 0;
> + timeout < IXGBE_VALIDATE_LINK_READY_TIMEOUT; timeout++) {
> + hw->phy.ops.read_reg(hw, MDIO_STAT1, MDIO_MMD_AN, &an_reg);
> +
> + if ((an_reg & MDIO_AN_STAT1_COMPLETE) &&
> + (an_reg & MDIO_STAT1_LSTATUS))
> + break;
> +
> + mdelay(100);
> + }
An up to 5000 msec non-preemptable spin loop.
If this used "msleep()" that would make it OK.
But as it is, sorry, no way.
next prev parent reply other threads:[~2009-12-14 3:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 7:51 [net-2.6 PATCH 1/3] ixgbe: Fix compiler warning about variable being used uninitialized Jeff Kirsher
2009-12-12 7:51 ` [net-2.6 PATCH 2/3] ixgbe: Fix tx_restart_queue/non_eop_desc statistics counters Jeff Kirsher
2009-12-14 3:18 ` David Miller
2009-12-14 4:57 ` Peter P Waskiewicz Jr
2009-12-14 5:07 ` David Miller
2009-12-12 7:52 ` [net-2.6 PATCH 3/3] Fix 82598 premature copper PHY link indicatation Jeff Kirsher
2009-12-14 3:18 ` David Miller [this message]
2009-12-14 18:37 ` Malli
2009-12-14 3:20 ` [net-2.6 PATCH 1/3] ixgbe: Fix compiler warning about variable being used uninitialized David Miller
2009-12-14 4:55 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091213.191858.71104129.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mallikarjuna.chilakala@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).