netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: lists@nerdbynature.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: Badness at net/ipv4/inet_connection_sock.c:293
Date: Sun, 13 Dec 2009 23:45:30 -0800 (PST)	[thread overview]
Message-ID: <20091213.234530.82029083.davem@davemloft.net> (raw)
In-Reply-To: <4B25D38F.1090702@gmail.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Dec 2009 06:56:31 +0100

> It seems to me tcp_create_openreq_child() doesnt properly initialize
> newtp->cookie_values to NULL, but this should not produce warnings like that ?

If oldtp->cookie_values is NULL, the child's should be as well
because of sk_clone().

  reply	other threads:[~2009-12-14  7:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-12  7:43 Badness at net/ipv4/inet_connection_sock.c:293 Christian Kujau
2009-12-12  9:03 ` David Miller
2009-12-12  9:22   ` Eric Dumazet
2009-12-12 10:06     ` lists
2009-12-14  5:56     ` Eric Dumazet
2009-12-14  7:45       ` David Miller [this message]
2009-12-14 17:34         ` Eric Dumazet
2009-12-14 18:19           ` David Miller
2009-12-14 18:57           ` John Dykstra
2009-12-14 19:11             ` David Miller
2009-12-14 19:16               ` David Miller
2009-12-14 19:23                 ` Eric Dumazet
2009-12-14 19:26                   ` David Miller
2009-12-14 22:35                   ` David Miller
2009-12-15  7:18                     ` David Miller
2009-12-15  8:45                       ` Eric Dumazet
2009-12-16  4:50                       ` David Miller
2009-12-16  4:57                         ` David Miller
2009-12-14 19:22               ` Eric Dumazet
2009-12-14 19:24                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091213.234530.82029083.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).