* [PATCH] sky2: print Optima chip name
@ 2009-12-14 18:33 Stephen Hemminger
2009-12-15 6:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2009-12-14 18:33 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Off by one in name lookup makes Optima display as (chip 0xbc)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2009-12-11 11:09:34.515284818 -0800
+++ b/drivers/net/sky2.c 2009-12-11 11:11:58.621253981 -0800
@@ -4530,7 +4530,7 @@ static const char *sky2_name(u8 chipid,
"Optima", /* 0xbc */
};
- if (chipid >= CHIP_ID_YUKON_XL && chipid < CHIP_ID_YUKON_OPT)
+ if (chipid >= CHIP_ID_YUKON_XL && chipid <= CHIP_ID_YUKON_OPT)
strncpy(buf, name[chipid - CHIP_ID_YUKON_XL], sz);
else
snprintf(buf, sz, "(chip %#x)", chipid);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sky2: print Optima chip name
2009-12-14 18:33 [PATCH] sky2: print Optima chip name Stephen Hemminger
@ 2009-12-15 6:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-15 6:07 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 14 Dec 2009 10:33:47 -0800
> Off by one in name lookup makes Optima display as (chip 0xbc)
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-15 6:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-14 18:33 [PATCH] sky2: print Optima chip name Stephen Hemminger
2009-12-15 6:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).