From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
mallikarjuna.chilakala@intel.com,
peter.p.waskiewicz.jr@intel.com
Subject: Re: [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop_desc statistics counters
Date: Tue, 15 Dec 2009 23:16:51 -0800 (PST) [thread overview]
Message-ID: <20091215.231651.144154754.davem@davemloft.net> (raw)
In-Reply-To: <20091215.211354.189718802.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 15 Dec 2009 21:13:54 -0800 (PST)
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Tue, 15 Dec 2009 13:56:59 -0800
>
>> From: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
>>
>> Fix the restart_queue and non_eop_desc counters from being
>> double-counted. They are cumulative in each ring, so we don't want to
>> add them to the cumulative result in the adapter's master counter.
>> Otherwise, the stats will be inaccurate
>>
>> Signed-off-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
>> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> Applied.
So how did you build test this?
drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_update_stats’:
drivers/net/ixgbe/ixgbe_main.c:4532: error: invalid type argument of ‘->’ (have ‘struct ixgbe_ring’)
drivers/net/ixgbe/ixgbe_main.c:4536: error: invalid type argument of ‘->’ (have ‘struct ixgbe_ring’)
next prev parent reply other threads:[~2009-12-16 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 21:56 [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop_desc statistics counters Jeff Kirsher
2009-12-15 21:57 ` [net-2.6 PATCH v2 2/2] ixgbe: Fix 82598 premature copper PHY link indicatation Jeff Kirsher
2009-12-16 5:14 ` David Miller
2009-12-16 5:13 ` [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop_desc statistics counters David Miller
2009-12-16 7:16 ` David Miller [this message]
2009-12-16 7:18 ` David Miller
2009-12-16 16:29 ` Chilakala, Mallikarjuna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215.231651.144154754.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mallikarjuna.chilakala@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).