* BUG null dereference in driver ./drivers/net/3c507.c
@ 2009-12-15 17:55 Alexander Strakh
2009-12-15 14:14 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Strakh @ 2009-12-15 17:55 UTC (permalink / raw)
To: Donald Becker, netdev, linux-kernel
KERNEL_VERSION: 2.6.32
SUBJECT: null dereference aftre check
DESCRIBE:
In driver drivers/net/3c507.c in function Iirqreturn_t el16_interrupt:
1. If in line 555 dev = NULL then we goto line 556
2. In line 556 we have null dereference because pr_err called with dev->name
in third parameter.
555 if (dev == NULL) {
556 pr_err("%s: net_interrupt(): irq %d for unknown device.
\n",
557 dev->name, irq);
558 return IRQ_NONE;
559 }
Found by Linux Device Drivers Verification Project (Svace Detector)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: BUG null dereference in driver ./drivers/net/3c507.c
2009-12-15 17:55 BUG null dereference in driver ./drivers/net/3c507.c Alexander Strakh
@ 2009-12-15 14:14 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-12-15 14:14 UTC (permalink / raw)
To: Alexander Strakh; +Cc: Donald Becker, netdev, linux-kernel
Hi,
On Tuesday 15 December 2009 06:55:08 pm Alexander Strakh wrote:
> KERNEL_VERSION: 2.6.32
> SUBJECT: null dereference aftre check
> DESCRIBE:
> In driver drivers/net/3c507.c in function Iirqreturn_t el16_interrupt:
>
> 1. If in line 555 dev = NULL then we goto line 556
> 2. In line 556 we have null dereference because pr_err called with dev->name
> in third parameter.
>
> 555 if (dev == NULL) {
> 556 pr_err("%s: net_interrupt(): irq %d for unknown device.
> \n",
> 557 dev->name, irq);
> 558 return IRQ_NONE;
> 559 }
There is no NULL dereference bug there possible since 'dev' will never be
actually NULL in el16_interrupt() (because of the way IRQ kernel subsystem
and 3c507 network driver are designed/work).
IOW it is just a bogus NULL pointer check, though it still would be nice
to have the issue fixed. Care to send a patch removing it?
--
Bartlomiej Zolnierkiewicz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-15 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 17:55 BUG null dereference in driver ./drivers/net/3c507.c Alexander Strakh
2009-12-15 14:14 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).