From: "John W. Linville" <linville@tuxdriver.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: Dan Williams <dcbw@redhat.com>,
linux-kernel@vger.kernel.org,
Holger Schurig <holgerschurig@gmail.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Maithili Hinge <maithili@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Michael Hirsch <m.hirsch@raumfeld.com>,
netdev@vger.kernel.org, libertas-dev@lists.infradead.org,
linux-wireless@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] Libertas: fix buffer overflow in lbs_get_essid()
Date: Wed, 16 Dec 2009 20:01:15 -0500 [thread overview]
Message-ID: <20091217010114.GA2913@tuxdriver.com> (raw)
In-Reply-To: <20091216231508.GX28375@buzzloop.caiaq.de>
On Thu, Dec 17, 2009 at 07:15:08AM +0800, Daniel Mack wrote:
> On Wed, Dec 16, 2009 at 08:57:47AM -0800, Dan Williams wrote:
> > On Wed, 2009-12-16 at 05:12 +0100, Daniel Mack wrote:
> > > The libertas driver copies the SSID buffer back to the wireless core and
> > > appends a trailing NULL character for termination. This is
> > >
> > > a) unnecessary because the buffer is allocated with kzalloc and is hence
> > > already NULLed when this function is called, and
> > >
> > > b) for priv->curbssparams.ssid_len == 32, it writes back one byte too
> > > much which causes memory corruptions.
> > >
> > > Fix this by removing the extra write.
> >
> > Acked-by: Dan Williams <dcbw@redhat.com>
>
> Thanks, everyone. Who will care to pick an queue this one?
Is there some reason it wouldn't be me?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-12-17 1:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 4:12 [PATCH] Libertas: fix buffer overflow in lbs_get_essid() Daniel Mack
2009-12-16 4:18 ` Daniel Mack
2009-12-16 8:15 ` Holger Schurig
2009-12-16 16:57 ` Dan Williams
2009-12-16 23:15 ` Daniel Mack
2009-12-17 1:01 ` John W. Linville [this message]
2009-12-17 1:19 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217010114.GA2913@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=daniel@caiaq.de \
--cc=dcbw@redhat.com \
--cc=dkiran@marvell.com \
--cc=holgerschurig@gmail.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.hirsch@raumfeld.com \
--cc=maithili@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).