From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: fabio.ludovici@yahoo.it, netdev@vger.kernel.org
Subject: Re: [PATCH] netem/iproute2 solving correlated loss issues [2/5]
Date: Fri, 18 Dec 2009 20:01:58 -0800 (PST) [thread overview]
Message-ID: <20091218.200158.112585402.davem@davemloft.net> (raw)
In-Reply-To: <20091218093605.76903fe5@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 18 Dec 2009 09:36:05 -0800
> On Fri, 18 Dec 2009 12:24:38 +0100
> Fabio Ludovici <fabio.ludovici@yahoo.it> wrote:
>
>> patch 2/5 : linux-2.6.32/net/sched/sch_netem.c
>
> Could you send with official signed-off-by line please?
>
> Need some style work to match kernel coding style (not a big issue).
> And it would be helpful to put in more descriptive variable names
> or documentation. But I will try and address these and resubmit,
> keeping you as original author.
I would like some kind of commit message which at least
explains what in the world this stuff is, how it works,
why we want it etc.
Furthermore it is fundamentally flawed in it's implementation
in that the user exported data structures cannot be changed,
you cannot change the layout and you absolutely cannot
change the size of these things or else various tool and
kernel combinations stop working.
next prev parent reply other threads:[~2009-12-19 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B2B5A26.8050400@uniroma2.it>
2009-12-18 11:24 ` [PATCH] netem/iproute2 solving correlated loss issues [2/5] Fabio Ludovici
2009-12-18 17:36 ` Stephen Hemminger
2009-12-18 23:49 ` Stefano Salsano
2009-12-19 4:01 ` David Miller [this message]
2009-12-19 9:48 ` Stefano Salsano
2009-12-18 11:27 ` [PATCH] netem/iproute2 solving correlated loss issues [3/5] Fabio Ludovici
2009-12-18 11:30 ` [PATCH] netem/iproute2 solving correlated loss issues [4/5] Fabio Ludovici
[not found] ` <4B2B5A65.1060300@uniroma2.it>
2009-12-18 11:30 ` [PATCH] netem/iproute2 solving correlated loss issues [5/5] Fabio Ludovici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218.200158.112585402.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabio.ludovici@yahoo.it \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).