netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stefano.salsano@uniroma2.it
Cc: netdev@vger.kernel.org, fabio.ludovici@yahoo.it
Subject: Re: [PATCH] netem/iproute2 solving correlated loss issues [0/5]
Date: Fri, 18 Dec 2009 20:04:06 -0800 (PST)	[thread overview]
Message-ID: <20091218.200406.183057577.davem@davemloft.net> (raw)
In-Reply-To: <4B2B5BD1.7040602@uniroma2.it>

From: Stefano Salsano <stefano.salsano@uniroma2.it>
Date: Fri, 18 Dec 2009 11:39:13 +0100

> The patch is backward compatible, we have not removed the previous
> correlated loss generated approach (though its use should be
> deprecated), nor we have changed anything else in the existing netem
> module.

To heck it is!

The changed version of iproute2 will not work without the kernel
changes installed.  The kernel validates the size of the structures
passed in, you can't change the user visible interface like this.

Add new netlink attributes to extend things, that's the "real"
backwards compatible way to make changes to netlink interfaces.

  parent reply	other threads:[~2009-12-19  4:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 10:39 [PATCH] netem/iproute2 solving correlated loss issues [0/5] Stefano Salsano
2009-12-18 11:22 ` Fabio Ludovici
2009-12-19  4:04 ` David Miller [this message]
2009-12-19  9:45   ` Stefano Salsano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091218.200406.183057577.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fabio.ludovici@yahoo.it \
    --cc=netdev@vger.kernel.org \
    --cc=stefano.salsano@uniroma2.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).