* [PATCH] netns: fix net.ipv6.route.gc_min_interval_ms in netns
@ 2009-12-18 14:16 Alexey Dobriyan
2009-12-19 4:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2009-12-18 14:16 UTC (permalink / raw)
To: davem; +Cc: netdev, dlezcano, benjamin.thery
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
Sorry for attachment, my patch sending facility is defunct right now.
Copying inline for review.
commit ee0270199605e58c76294f62ba8fbc0f583ccd3e
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri Dec 18 16:08:04 2009 +0200
netns: fix net.ipv6.route.gc_min_interval_ms in netns
sysctl table was copied, all right, but ->data for
net.ipv6.route.gc_min_interval_ms
was not reinitialized for "!= &init_net" case.
In init_net everthing works by accident due to correct ->data initialization
in source table.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index db3b273..c2bd74c 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2630,6 +2630,7 @@ struct ctl_table *ipv6_route_sysctl_init(struct net *net)
table[6].data = &net->ipv6.sysctl.ip6_rt_gc_elasticity;
table[7].data = &net->ipv6.sysctl.ip6_rt_mtu_expires;
table[8].data = &net->ipv6.sysctl.ip6_rt_min_advmss;
+ table[9].data = &net->ipv6.sysctl.ip6_rt_gc_min_interval;
}
return table;
[-- Attachment #2: gc-min-interval.patch --]
[-- Type: text/x-diff, Size: 963 bytes --]
commit ee0270199605e58c76294f62ba8fbc0f583ccd3e
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri Dec 18 16:08:04 2009 +0200
netns: fix net.ipv6.route.gc_min_interval_ms in netns
sysctl table was copied, all right, but ->data for net.ipv6.route.gc_min_interval_ms
was not reinitialized for "!= &init_net" case.
In init_net everthing works by accident due to correct ->data initialization
in source table.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index db3b273..c2bd74c 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2630,6 +2630,7 @@ struct ctl_table *ipv6_route_sysctl_init(struct net *net)
table[6].data = &net->ipv6.sysctl.ip6_rt_gc_elasticity;
table[7].data = &net->ipv6.sysctl.ip6_rt_mtu_expires;
table[8].data = &net->ipv6.sysctl.ip6_rt_min_advmss;
+ table[9].data = &net->ipv6.sysctl.ip6_rt_gc_min_interval;
}
return table;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netns: fix net.ipv6.route.gc_min_interval_ms in netns
2009-12-18 14:16 [PATCH] netns: fix net.ipv6.route.gc_min_interval_ms in netns Alexey Dobriyan
@ 2009-12-19 4:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-19 4:11 UTC (permalink / raw)
To: adobriyan; +Cc: netdev, dlezcano, benjamin.thery
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 18 Dec 2009 16:16:40 +0200
> netns: fix net.ipv6.route.gc_min_interval_ms in netns
>
> sysctl table was copied, all right, but ->data for
> net.ipv6.route.gc_min_interval_ms
> was not reinitialized for "!= &init_net" case.
>
> In init_net everthing works by accident due to correct ->data initialization
> in source table.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-19 4:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-18 14:16 [PATCH] netns: fix net.ipv6.route.gc_min_interval_ms in netns Alexey Dobriyan
2009-12-19 4:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).