From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: bjorn.helgaas@hp.com, amit.salecha@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: NetXen crash in sysfs_create_file
Date: Fri, 18 Dec 2009 20:14:00 -0800 (PST) [thread overview]
Message-ID: <20091218.201400.260092381.davem@davemloft.net> (raw)
In-Reply-To: <20091218162054.7b19d98f@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 18 Dec 2009 16:20:54 -0800
> Subject: [PATCH] netxen: use module parameter correctly
>
> Netxen driver is doing this bogus thing to create a control file.
> This fails if device doesn't exist, and overall is a bad way to do
> the module parameter. Rather than fix borked code, just rewrite.
> Just using a writeable module parameter of 0/1 is the correct way
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
prev parent reply other threads:[~2009-12-19 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 20:24 NetXen crash in sysfs_create_file Bjorn Helgaas
2009-12-19 0:20 ` Stephen Hemminger
2009-12-19 4:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218.201400.260092381.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amit.salecha@qlogic.com \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).