From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Roel Kluin" <roel.kluin@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Matthew Carlson" <mcarlson@broadcom.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()
Date: Thu, 17 Dec 2009 17:41:39 -0800 [thread overview]
Message-ID: <20091218014138.GA22080@xw6200.broadcom.net> (raw)
In-Reply-To: <4B28DA62.40909@gmail.com>
On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
> If not signed read errors are ignored.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Matt Carlson <mcarlson@broadcom.com>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index f63c96a..c13cf64 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -326,7 +326,8 @@ error:
>
> static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
> {
> - u32 val, orig;
> + u32 orig;
> + int val;
> bool clk125en = true;
>
> /* Abort if we are using an untested phy. */
>
next prev parent reply other threads:[~2009-12-18 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 13:02 [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk() Roel Kluin
2009-12-18 1:41 ` Matt Carlson [this message]
2009-12-19 4:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218014138.GA22080@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).