From: Michael Guntsche <mike@it-loops.com>
To: Kumar Gopalpet-B05799 <B05799@freescale.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [BUG] 2.6.33-rc1 gianfar error message
Date: Tue, 22 Dec 2009 19:27:57 +0100 [thread overview]
Message-ID: <20091222182756.GA71759@trillian.comsick.at> (raw)
In-Reply-To: <20091222181000.GA71727@trillian.comsick.at>
On 2009.12.22 19:10:00 , Michael Guntsche wrote:
> Since you said that the first patch is not needed
>
> @@ -2470,10 +2470,11 @@ static int gfar_process_frame(struct net_device
> fcb = (struct rxfcb *)skb->data;
>
> /* Remove the FCB from the skb */
> - skb_set_queue_mapping(skb, fcb->rq);
> /* Remove the padded bytes, if there are any */
> - if (amount_pull)
> + if (amount_pull) {
> + skb_set_queue_mapping(skb, fcb->rq);
> skb_pull(skb, amount_pull);
> + }
>
> if (priv->rx_csum_enable)
> gfar_rx_checksum(skb, fcb);
>
> I only applied the second one and tested again. Right after the reboot
> I got an error so apparently this change IS required as well.
I tested this now in the opposite direction and apparently ONLY this
patch is needed. I commented out the second diff and did not get any
errors so far. Sorry for not testing this before sending my previous
mail.
Kind regards,
Michael
next prev parent reply other threads:[~2009-12-22 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 21:44 [BUG] 2.6.33-rc1 gianfar error message Michael Guntsche
2009-12-21 4:28 ` Kumar Gopalpet-B05799
2009-12-21 7:27 ` Michael Guntsche
2009-12-21 8:49 ` Kumar Gopalpet-B05799
2009-12-21 16:38 ` Michael Guntsche
2009-12-22 5:02 ` Kumar Gopalpet-B05799
2009-12-22 11:52 ` Michael Guntsche
2009-12-22 18:10 ` Michael Guntsche
2009-12-22 18:27 ` Michael Guntsche [this message]
2009-12-23 14:15 ` Kumar Gopalpet-B05799
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222182756.GA71759@trillian.comsick.at \
--to=mike@it-loops.com \
--cc=B05799@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).