From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ep93xx_eth.c: general cleanup Date: Wed, 23 Dec 2009 14:14:58 -0800 (PST) Message-ID: <20091223.141458.193725880.davem@davemloft.net> References: <20091216183200.GN1819@mail.wantstofly.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: buytenh@wantstofly.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, joe@perches.com To: hartleys@visionengravers.com Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "H Hartley Sweeten" Date: Wed, 16 Dec 2009 13:34:55 -0500 > Wednesday, December 16, 2009 11:32 AM, Lennert Buytenhek wrote: >> On Wed, Dec 16, 2009 at 01:18:13PM -0500, H Hartley Sweeten wrote: >> >>> V3 - Change pr_fmt() as suggested by Joe Perches >>> Don't remove DRV_MODULE_NAME and DRV_MODULE_VERSION >>> Don't remove the message in ep93xx_eth_init_module() >> >> That's not what I meant, but alright, as you prefer. > > Guess my parser is off line today.... ;-) > > What did you mean? This patch also doesn't apply to current sources, so if you could also please respin this once you've resolved the feedback that would be great. Thanks.