gianfar select_queue bogosity (was Re: ixgbe warning)

[David Miller <davem@davemloft.net>]

From: Krishna Kumar2 <krkumar2@in.ibm.com>
Date: Wed, 23 Dec 2009 12:57:26 +0530

> Also, I was looking at other providers of select_queue and found:
> 
> u16 gfar_select_queue(struct net_device *dev, struct sk_buff *skb)
> {
>         return skb_get_queue_mapping(skb);
> }
> 
> How can this be correct (driver supports upto 8 txq's). Unless txq=0 for
> xmits of all locally
> generated packets is fine.

This must be fixed.  As you note the queue mapping is only set
for forwarding/bridging cases.

There is zero reason for this driver to have it's own select_queue
function, so the fix seems to simply remove this thing altogether.

Some gianfar developer please prepare such a patch, thanks.