From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org, 508527@bugs.debian.org
Subject: Re: [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change
Date: Fri, 25 Dec 2009 18:21:02 -0800 (PST) [thread overview]
Message-ID: <20091225.182102.112589642.davem@davemloft.net> (raw)
In-Reply-To: <1260842710.4532.691.camel@localhost>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Tue, 15 Dec 2009 02:05:09 +0000
> velocity_open() calls velocity_give_many_rx_descs(), which gives RX
> descriptors to the NIC, before installing an interrupt handler or
> calling velocity_init_registers(). I think this is very unsafe and it
> appears to explain the bug report <http://bugs.debian.org/508527>.
>
> On MTU change, velocity_give_many_rx_descs() is again called before
> velocity_init_registers(). I'm not sure whether this is unsafe but
> it does look wrong.
>
> Therefore, move the calls to velocity_give_many_rx_descs() after
> request_irq() and velocity_init_registers().
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> This is untested; I don't have this hardware.
Although this patch looks fine to me, I don't want to apply
it until someone tests it.
next prev parent reply other threads:[~2009-12-26 2:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 2:05 [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change Ben Hutchings
2009-12-26 2:21 ` David Miller [this message]
2009-12-28 9:27 ` Jan Ceuleers
2009-12-28 9:36 ` Jan Ceuleers
2010-01-04 5:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091225.182102.112589642.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=508527@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).