netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [RESEND PATCH 1/4] stmmac: thinking about a generic driver for Synopsys Controllers.
Date: Fri, 25 Dec 2009 18:26:45 -0800 (PST)	[thread overview]
Message-ID: <20091225.182645.59702958.davem@davemloft.net> (raw)
In-Reply-To: <1260948405-28511-1-git-send-email-peppe.cavallaro@st.com>

From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Wed, 16 Dec 2009 08:26:42 +0100

> The idea behind this patch is to start thinking about a
> generic driver for Synopsys Ethernet Controllers
> starting from the stmmac device driver.

This patch does too much at once.

It changes Kconfig help test.

It moves many things around to many new files.

It's therefore too large to review as a unit.

Please split this up into several (many) pieces.
One for each specific action.

One patch might improve the help test.  Another might
move DMA operations out to a seperate file, another might
move another class of operations into a new file.

And at each step of the way the driver must compile and work
properly.

Thanks.

  parent reply	other threads:[~2009-12-26  2:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16  7:26 [RESEND PATCH 1/4] stmmac: thinking about a generic driver for Synopsys Controllers Giuseppe CAVALLARO
2009-12-16  7:26 ` [RESEND PATCH 2/4] stmmac: add the new Header file for stmmac platform data Giuseppe CAVALLARO
2009-12-16  7:26   ` [RESEND PATCH 3/4] stmmac: use MII_BUS_ID_SIZE instead of BUS_ID_SIZE Giuseppe CAVALLARO
2009-12-16  7:26     ` [RESEND PATCH 4/4] stmmac: convert unicast addr list to list_head Giuseppe CAVALLARO
2009-12-26  2:25   ` [RESEND PATCH 2/4] stmmac: add the new Header file for stmmac platform data David Miller
2010-01-04  7:22     ` Giuseppe CAVALLARO
2009-12-26  2:26 ` David Miller [this message]
2010-01-04  7:21   ` [RESEND PATCH 1/4] stmmac: thinking about a generic driver for Synopsys Controllers Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091225.182645.59702958.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).