* [PATCH 1/2] iproute2 skbedit: Fix help message
@ 2009-12-03 13:27 jamal
2009-12-26 19:07 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: jamal @ 2009-12-03 13:27 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Alexander Duyck
[-- Attachment #1: Type: text/plain, Size: 135 bytes --]
Currently the help text for skbedit implies you can either pass queue
mapping or priority. Truth is you can pass both
cheers,
jamal
[-- Attachment #2: skbehelp-p --]
[-- Type: text/plain, Size: 906 bytes --]
commit ca50bc332fc8f2cba0468fe133d41d78a0be7b71
Author: Jamal Hadi Salim <hadi@cyberus.ca>
Date: Thu Dec 3 08:14:11 2009 -0500
skbedit: Fix help message
Currently the help text implies you can either pass queue mapping
or priority. Truth is you can pass both
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 9044353..ecb1f2d 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -31,8 +31,9 @@
static void
explain(void)
{
- fprintf(stderr, "Usage: ... skbedit "
- "queue_mapping QUEUE_MAPPING | priority PRIORITY \n"
+ fprintf(stderr, "Usage: ... skbedit <[QM] [PM]>\n"
+ "QM = queue_mapping QUEUE_MAPPING\n"
+ "PM = priority PRIORITY \n"
"QUEUE_MAPPING = device transmit queue to use\n"
"PRIORITY = classID to assign to priority field\n");
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] iproute2 skbedit: Fix help message
2009-12-03 13:27 [PATCH 1/2] iproute2 skbedit: Fix help message jamal
@ 2009-12-26 19:07 ` Stephen Hemminger
2009-12-26 21:12 ` jamal
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2009-12-26 19:07 UTC (permalink / raw)
To: hadi; +Cc: netdev, Alexander Duyck
On Thu, 03 Dec 2009 08:27:24 -0500
jamal <hadi@cyberus.ca> wrote:
>
> Currently the help text for skbedit implies you can either pass queue
> mapping or priority. Truth is you can pass both
>
> cheers,
> jamal
>
applied to 2.6.32 version
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] iproute2 skbedit: Fix help message
2009-12-26 19:07 ` Stephen Hemminger
@ 2009-12-26 21:12 ` jamal
0 siblings, 0 replies; 3+ messages in thread
From: jamal @ 2009-12-26 21:12 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Alexander Duyck
On Sat, 2009-12-26 at 11:07 -0800, Stephen Hemminger wrote:
> On Thu, 03 Dec 2009 08:27:24 -0500
> jamal <hadi@cyberus.ca> wrote:
>
> >
> > Currently the help text for skbedit implies you can either pass queue
> > mapping or priority. Truth is you can pass both
> >
> > cheers,
> > jamal
> >
> applied to 2.6.32 version
It is not in the 2.6.32 release - but seems harmless enough it can stay
in later versions.
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-26 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-03 13:27 [PATCH 1/2] iproute2 skbedit: Fix help message jamal
2009-12-26 19:07 ` Stephen Hemminger
2009-12-26 21:12 ` jamal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).