From: Dan Carpenter <error27@gmail.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch] hamradio: avoid null deref v2
Date: Sat, 26 Dec 2009 14:38:12 +0200 [thread overview]
Message-ID: <20091226123812.GB6075@bicker> (raw)
In-Reply-To: <4B3257C2.2050500@gmail.com>
Bump the stats on the original dev not on the newly assigned NULL version of
dev.
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/net/hamradio/bpqether.c 2009-12-22 23:58:56.000000000 +0200
+++ devel/drivers/net/hamradio/bpqether.c 2009-12-25 19:49:05.000000000 +0200
@@ -282,11 +282,12 @@ static netdev_tx_t bpq_xmit(struct sk_bu
bpq = netdev_priv(dev);
- if ((dev = bpq_get_ether_dev(dev)) == NULL) {
+ if (!bpq->ethdev) {
dev->stats.tx_dropped++;
kfree_skb(skb);
return NETDEV_TX_OK;
}
+ dev = bpq_get_ether_dev(dev);
skb->protocol = ax25_type_trans(skb, dev);
skb_reset_network_header(skb);
next prev parent reply other threads:[~2009-12-26 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 13:25 [patch] hamradio: avoid null deref Dan Carpenter
2009-12-23 17:47 ` Jarek Poplawski
2009-12-23 21:32 ` David Miller
2009-12-26 12:38 ` Dan Carpenter [this message]
2009-12-27 4:17 ` [patch] hamradio: avoid null deref v2 David Miller
2009-12-28 16:54 ` [patch] hamradio: avoid null deref v3 Dan Carpenter
2010-01-04 5:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091226123812.GB6075@bicker \
--to=error27@gmail.com \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).