* Re: [PATCH] tcp: for tcp westwood implementation
@ 2009-12-28 6:35 Jae-Hyun Hwang
2009-12-28 8:43 ` Jarek Poplawski
0 siblings, 1 reply; 7+ messages in thread
From: Jae-Hyun Hwang @ 2009-12-28 6:35 UTC (permalink / raw)
To: netdev
I'm sorry about posting such a damaged email.
I resubmit the patch by plain-text.
From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected, it is more natural that the interface points to
'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when
CA_EVENT_LOSS event is generated as explained in the papers.
Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
---
--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28
13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
westwood_fast_bw(sk);
break;
- case CA_EVENT_COMPLETE_CWR:
- tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
- break;
-
case CA_EVENT_FRTO:
- tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
/* Update RTT_min when next ack arrives */
w->reset_rtt_min = 1;
break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
static struct tcp_congestion_ops tcp_westwood = {
.init = tcp_westwood_init,
- .ssthresh = tcp_reno_ssthresh,
+ .ssthresh = tcp_westwood_bw_rttmin,
.cong_avoid = tcp_reno_cong_avoid,
- .min_cwnd = tcp_westwood_bw_rttmin,
.cwnd_event = tcp_westwood_event,
.get_info = tcp_westwood_info,
.pkts_acked = tcp_westwood_pkts_acked,
--
On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
>
- Hide quoted text -
> Annyoung-haseyo,
>
> Your patch was damaged by your email client (long lines
> were chopped up with newlines, etc.), as such it is not
> usable.
>
> Please fix this up and resubmit your patch.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tcp: for tcp westwood implementation
2009-12-28 6:35 [PATCH] tcp: for tcp westwood implementation Jae-Hyun Hwang
@ 2009-12-28 8:43 ` Jarek Poplawski
2009-12-28 10:52 ` Jae-Hyun Hwang
0 siblings, 1 reply; 7+ messages in thread
From: Jarek Poplawski @ 2009-12-28 8:43 UTC (permalink / raw)
To: Jae-Hyun Hwang; +Cc: netdev
On 28-12-2009 07:35, Jae-Hyun Hwang wrote:
> I'm sorry about posting such a damaged email.
> I resubmit the patch by plain-text.
Most probably it's still wrong (e.g. no tabs).
http://marc.info/?l=linux-netdev&m=126198215600946&q=raw
Did you try to send it to yourself?
Jarek P.
>
> From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
>
> Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
> with Westwood papers.
> Since Linux TCP calls '.ssthresh' interface whenever packet loss is
> detected, it is more natural that the interface points to
> 'tcp_westwood_bw_rttmin' function, not Reno's function.
> This patch also enables Westwood to perform its algorithm when
> CA_EVENT_LOSS event is generated as explained in the papers.
>
> Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
> ---
>
> --- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
> 13:35:42.000000000 +0900
> +++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28
> 13:36:54.000000000 +0900
> @@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
> westwood_fast_bw(sk);
> break;
>
> - case CA_EVENT_COMPLETE_CWR:
> - tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> - break;
> -
> case CA_EVENT_FRTO:
> - tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> /* Update RTT_min when next ack arrives */
> w->reset_rtt_min = 1;
> break;
> @@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
>
> static struct tcp_congestion_ops tcp_westwood = {
> .init = tcp_westwood_init,
> - .ssthresh = tcp_reno_ssthresh,
> + .ssthresh = tcp_westwood_bw_rttmin,
> .cong_avoid = tcp_reno_cong_avoid,
> - .min_cwnd = tcp_westwood_bw_rttmin,
> .cwnd_event = tcp_westwood_event,
> .get_info = tcp_westwood_info,
> .pkts_acked = tcp_westwood_pkts_acked,
> --
>
> On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
> - Hide quoted text -
>> Annyoung-haseyo,
>>
>> Your patch was damaged by your email client (long lines
>> were chopped up with newlines, etc.), as such it is not
>> usable.
>>
>> Please fix this up and resubmit your patch.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tcp: for tcp westwood implementation
2009-12-28 8:43 ` Jarek Poplawski
@ 2009-12-28 10:52 ` Jae-Hyun Hwang
2009-12-28 12:32 ` Jarek Poplawski
0 siblings, 1 reply; 7+ messages in thread
From: Jae-Hyun Hwang @ 2009-12-28 10:52 UTC (permalink / raw)
To: Jarek Poplawski; +Cc: netdev
Is it still wrong?
I hope this patch is successful.
From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected, it is more natural that the interface points to
'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when
CA_EVENT_LOSS event is generated as explained in the papers.
Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
---
--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28 13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
westwood_fast_bw(sk);
break;
- case CA_EVENT_COMPLETE_CWR:
- tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
- break;
-
case CA_EVENT_FRTO:
- tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
/* Update RTT_min when next ack arrives */
w->reset_rtt_min = 1;
break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
static struct tcp_congestion_ops tcp_westwood = {
.init = tcp_westwood_init,
- .ssthresh = tcp_reno_ssthresh,
+ .ssthresh = tcp_westwood_bw_rttmin,
.cong_avoid = tcp_reno_cong_avoid,
- .min_cwnd = tcp_westwood_bw_rttmin,
.cwnd_event = tcp_westwood_event,
.get_info = tcp_westwood_info,
.pkts_acked = tcp_westwood_pkts_acked,
--
On Mon, Dec 28, 2009 at 5:43 PM, Jarek Poplawski <jarkao2@gmail.com> wrote:
> On 28-12-2009 07:35, Jae-Hyun Hwang wrote:
>> I'm sorry about posting such a damaged email.
>> I resubmit the patch by plain-text.
>
> Most probably it's still wrong (e.g. no tabs).
> http://marc.info/?l=linux-netdev&m=126198215600946&q=raw
>
> Did you try to send it to yourself?
>
> Jarek P.
>
>>
>> On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
>> - Hide quoted text -
>>> Annyoung-haseyo,
>>>
>>> Your patch was damaged by your email client (long lines
>>> were chopped up with newlines, etc.), as such it is not
>>> usable.
>>>
>>> Please fix this up and resubmit your patch.
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tcp: for tcp westwood implementation
2009-12-28 10:52 ` Jae-Hyun Hwang
@ 2009-12-28 12:32 ` Jarek Poplawski
2010-01-04 6:19 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Jarek Poplawski @ 2009-12-28 12:32 UTC (permalink / raw)
To: Jae-Hyun Hwang; +Cc: netdev
On Mon, Dec 28, 2009 at 07:52:23PM +0900, Jae-Hyun Hwang wrote:
> Is it still wrong?
> I hope this patch is successful.
I hope too, but it depends on David. This time it's mostly OK, execept
"Content-Transfer-Encoding: quoted-printable" instead of "inline", as
required by Documentation/SubmittingPatches.
Jarek P.
PS: Btw, don't leave old information after the patch (next time).
>
> From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
>
> Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
> with Westwood papers.
> Since Linux TCP calls '.ssthresh' interface whenever packet loss is
> detected, it is more natural that the interface points to
> 'tcp_westwood_bw_rttmin' function, not Reno's function.
> This patch also enables Westwood to perform its algorithm when
> CA_EVENT_LOSS event is generated as explained in the papers.
>
> Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
>
> ---
>
> --- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
> 13:35:42.000000000 +0900
> +++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28 13:36:54.000000000 +0900
> @@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
> westwood_fast_bw(sk);
> break;
>
> - case CA_EVENT_COMPLETE_CWR:
> - tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> - break;
> -
> case CA_EVENT_FRTO:
> - tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> /* Update RTT_min when next ack arrives */
> w->reset_rtt_min = 1;
> break;
> @@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
>
> static struct tcp_congestion_ops tcp_westwood = {
> .init = tcp_westwood_init,
> - .ssthresh = tcp_reno_ssthresh,
> + .ssthresh = tcp_westwood_bw_rttmin,
> .cong_avoid = tcp_reno_cong_avoid,
> - .min_cwnd = tcp_westwood_bw_rttmin,
> .cwnd_event = tcp_westwood_event,
> .get_info = tcp_westwood_info,
> .pkts_acked = tcp_westwood_pkts_acked,
> --
>
>
>
> On Mon, Dec 28, 2009 at 5:43 PM, Jarek Poplawski <jarkao2@gmail.com> wrote:
> > On 28-12-2009 07:35, Jae-Hyun Hwang wrote:
> >> I'm sorry about posting such a damaged email.
> >> I resubmit the patch by plain-text.
> >
> > Most probably it's still wrong (e.g. no tabs).
> > http://marc.info/?l=linux-netdev&m=126198215600946&q=raw
> >
> > Did you try to send it to yourself?
> >
> > Jarek P.
> >
> >>
> >> On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
> >> - Hide quoted text -
> >>> Annyoung-haseyo,
> >>>
> >>> Your patch was damaged by your email client (long lines
> >>> were chopped up with newlines, etc.), as such it is not
> >>> usable.
> >>>
> >>> Please fix this up and resubmit your patch.
> >>>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe netdev" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tcp: for tcp westwood implementation
2009-12-28 12:32 ` Jarek Poplawski
@ 2010-01-04 6:19 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2010-01-04 6:19 UTC (permalink / raw)
To: jarkao2; +Cc: jhhwang, netdev
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 28 Dec 2009 12:32:02 +0000
> On Mon, Dec 28, 2009 at 07:52:23PM +0900, Jae-Hyun Hwang wrote:
>> Is it still wrong?
>> I hope this patch is successful.
>
> I hope too, but it depends on David. This time it's mostly OK, execept
> "Content-Transfer-Encoding: quoted-printable" instead of "inline", as
> required by Documentation/SubmittingPatches.
Patchwork didn't pick it up either, it definitely needs to be
resent.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] tcp: for tcp westwood implementation
@ 2009-12-28 5:18 Hwang Jae-Hyun
2009-12-28 5:56 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Hwang Jae-Hyun @ 2009-12-28 5:18 UTC (permalink / raw)
To: netdev
From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with
Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected,
it is more natural that the interface points to 'tcp_westwood_bw_rttmin'
function, not Reno's function.
This patch also enables Westwood to perform its algorithm when CA_EVENT_LOSS
event is generated as explained in the papers.
Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
---
--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28
13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
westwood_fast_bw(sk);
break;
- case CA_EVENT_COMPLETE_CWR:
- tp->snd_cwnd = tp->snd_ssthresh =
tcp_westwood_bw_rttmin(sk);
- break;
-
case CA_EVENT_FRTO:
- tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
/* Update RTT_min when next ack arrives */
w->reset_rtt_min = 1;
break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
static struct tcp_congestion_ops tcp_westwood = {
.init = tcp_westwood_init,
- .ssthresh = tcp_reno_ssthresh,
+ .ssthresh = tcp_westwood_bw_rttmin,
.cong_avoid = tcp_reno_cong_avoid,
- .min_cwnd = tcp_westwood_bw_rttmin,
.cwnd_event = tcp_westwood_event,
.get_info = tcp_westwood_info,
.pkts_acked = tcp_westwood_pkts_acked,
--
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-04 6:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-28 6:35 [PATCH] tcp: for tcp westwood implementation Jae-Hyun Hwang
2009-12-28 8:43 ` Jarek Poplawski
2009-12-28 10:52 ` Jae-Hyun Hwang
2009-12-28 12:32 ` Jarek Poplawski
2010-01-04 6:19 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-12-28 5:18 Hwang Jae-Hyun
2009-12-28 5:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).