* [PATCH] drivers/net/usb/rtl8150.c: use %pM to shown MAC address
@ 2009-12-28 23:27 H Hartley Sweeten
2009-12-30 17:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-12-28 23:27 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: David Miller
Use the %pM kernel extension to display the MAC address.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David S. Miller <davem@davemloft.net>
---
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index f14d225..dfc7e9f 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -313,20 +313,17 @@ static int rtl8150_set_mac_address(struct net_device *netdev, void *p)
{
struct sockaddr *addr = p;
rtl8150_t *dev = netdev_priv(netdev);
- int i;
if (netif_running(netdev))
return -EBUSY;
memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
- dbg("%s: Setting MAC address to ", netdev->name);
- for (i = 0; i < 5; i++)
- dbg("%02X:", netdev->dev_addr[i]);
- dbg("%02X\n", netdev->dev_addr[i]);
+ dbg("%s: Setting MAC address to %pM\n", netdev->name, netdev->dev_addr);
/* Set the IDR registers. */
set_registers(dev, IDR, netdev->addr_len, netdev->dev_addr);
#ifdef EEPROM_WRITE
{
+ int i;
u8 cr;
/* Get the CR contents. */
get_registers(dev, CR, 1, &cr);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/usb/rtl8150.c: use %pM to shown MAC address
2009-12-28 23:27 [PATCH] drivers/net/usb/rtl8150.c: use %pM to shown MAC address H Hartley Sweeten
@ 2009-12-30 17:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-30 17:16 UTC (permalink / raw)
To: hartleys; +Cc: linux-kernel, netdev
From: "H Hartley Sweeten" <hartleys@visionengravers.com>
Date: Mon, 28 Dec 2009 18:27:27 -0500
> Use the %pM kernel extension to display the MAC address.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-30 17:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-28 23:27 [PATCH] drivers/net/usb/rtl8150.c: use %pM to shown MAC address H Hartley Sweeten
2009-12-30 17:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).