From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH] drivers/atm/lanai.c: use %pM to show MAC address Date: Wed, 30 Dec 2009 21:56:59 -0200 Message-ID: <20091230235659.GH18722@khazad-dum.debian.net> References: <1262199586.2545.43.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: H Hartley Sweeten , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, David Miller To: Joe Perches Return-path: Content-Disposition: inline In-Reply-To: <1262199586.2545.43.camel@Joe-Laptop.home> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 30 Dec 2009, Joe Perches wrote: > > + return sprintf(page, "EEPROM ESI: %pM\n", > > + &lanai->eeprom[EEPROM_MAC]); > > This is a user-visible change from upper case to lower case. > Probably doesn't matter, but maybe... Something would need to be _really_ broken to: 1. Parse the kernel log after MACs in the first place 2. Be case-sensitive about it If it breaks anything, it is a breakage well deserved... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh