From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690FAC282C3 for ; Tue, 22 Jan 2019 22:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2697A21726 for ; Tue, 22 Jan 2019 22:58:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4taEed9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbfAVW6l (ORCPT ); Tue, 22 Jan 2019 17:58:41 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40209 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfAVW6l (ORCPT ); Tue, 22 Jan 2019 17:58:41 -0500 Received: by mail-pf1-f194.google.com with SMTP id i12so114605pfo.7 for ; Tue, 22 Jan 2019 14:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1KMOCpUFo6XDySrAVsG8nD0OKwmDT4F9owQnlVMKyJw=; b=b4taEed9a8o1MKG7Tqd46qhchs2CEs1BR95QR5h5lIrcj5LdTiHCdexZfa8+GYeG8Z A1epQXDNzHCwB1Wd/hRJEu6aBvaFD8qJKwZ00Bf3astesRfcvBFmv0mQ83oLJXzP01dx NYNK7in1xp8IbaSBrO1SDQb/0maXH1HKo5PiAJrsbQELRD9GR/OJ/rOsvtX8yFdcCS9e sIZF8YiQ0evErUiVPxIpvBUF0MsyZ/NFHAQv3eAH/dVQ+d7TZw1zwwO3QvOqk6mAWHGc ylwH7xKCD3+OgDynmmGmf/YywvqG3HSXxYy8BbBSXUWRppowrFtgOg3V4ETx/nPLJyEw JCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1KMOCpUFo6XDySrAVsG8nD0OKwmDT4F9owQnlVMKyJw=; b=D8VEIvfcQP9vR9UmTDyuZs8pI8+fGCFEACQvJkMw4Ua7Re+BXUe5cO1b4PjaMR4122 ckW3aTuIxLt25Ldu89Ianz5D0Ccexs2aV/lEaZvWti6PElI+fmoKU+U3huZxonoscUKu wh5z7b0kl4HNsaJN+aVgmh/7WWsrhJLn9iQK+X8uiNbEvL4K616IeCTe8apfZa66b6Zp uUGRsRQlNUiU+5I7L5ud9lO9Z2pyeD2jVjL8jKmswF5nIC/cpt/bEeiqkktWpDpUZ2c/ dszamtZPrccUO2PFVJ0AF0dacKMpm/t57rVJ0Xx4jC9Vwk0xcBu1QvlbGHT2oG4K9lgR lYWA== X-Gm-Message-State: AJcUukd0F6TBNGmWsxu4ZAYOEW6nL9JxA4p7A6iZ2nvrOk2AI815hDyV P2+X9TNRJ0R0ofhbWqEo4TQ= X-Google-Smtp-Source: ALg8bN7NDFNTv/tctaM/bDPcsb8YaNu9LEa30W619A8mSJqX99sdmKTDAzpcVUVx19RAJ7D8Ly8zEQ== X-Received: by 2002:a63:1a4b:: with SMTP id a11mr34006536pgm.254.1548197920335; Tue, 22 Jan 2019 14:58:40 -0800 (PST) Received: from [10.67.49.9] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id b7sm28854578pga.39.2019.01.22.14.58.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 14:58:39 -0800 (PST) Subject: Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC To: =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Greg Ungerer Cc: Sean Wang , bjorn@mork.no, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, john@phrozen.org, neil@brown.name, linux-mediatek@lists.infradead.org References: <1548101433.24552.14.camel@mtkswgap22> <8b6746b2-2d90-99ba-c8e5-4e4089567155@kernel.org> <20190122211307.Horde.V6XcMCE3ZFBZOJMYl12Uxex@www.vdorst.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <200bd8ec-0e75-30f5-0444-323e4dc86210@gmail.com> Date: Tue, 22 Jan 2019 14:58:37 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190122211307.Horde.V6XcMCE3ZFBZOJMYl12Uxex@www.vdorst.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/22/19 1:13 PM, René van Dorst wrote: > Quoting Greg Ungerer : > > > >>>>        /* Reset whole chip through gpio pin or memory-mapped >>>> registers for @@ -1326,9 +1335,17 @@ static const struct >>>> dsa_switch_ops mt7530_switch_ops = { >>>>      .port_vlan_del        = mt7530_port_vlan_del, >>>>  }; >>>>  +static const struct of_device_id mt7530_of_match[] = { >>>> +    { .compatible = "mediatek,mt7621", .data = (void *)ID_MT7621, }, >>>> +    { .compatible = "mediatek,mt7530", .data = (void *)ID_MT7530, }, >>>> +    { /* sentinel */ }, >>>> +}; >>>> +MODULE_DEVICE_TABLE(of, mt7530_of_match); >>>> + >>>>  static int >>>>  mt7530_probe(struct mdio_device *mdiodev)  { >>>> +    const struct of_device_id *of_id; >>>>      struct mt7530_priv *priv; >>>>      struct device_node *dn; >>>>  @@ -1356,13 +1373,21 @@ mt7530_probe(struct mdio_device *mdiodev) >>>>          } >>>>      } >>>>  -    priv->core_pwr = devm_regulator_get(&mdiodev->dev, "core"); >>>> -    if (IS_ERR(priv->core_pwr)) >>>> -        return PTR_ERR(priv->core_pwr); >>>> +    /* Get the hardware identifier from the devicetree node. >>>> +     * We will need it for some of the clock and regulator setup. >>>> +     */ >>>> +    of_id = of_match_node(mt7530_of_match, dn); >>>> +    priv->id = (unsigned int)of_id->data; >>>> >>> >>> We could use of_device_get_match_data instead of the above two lines. >> >> Yep, good idea. Will change. I will add in some extra >> casting to take care of the kbuild warning too. >> >> >>> and could you help Cc linux-mediatek@lists.infradead.org if you have the >>> next version for the series ? >> >> Yep, sure thing. >> >> Regards >> Greg > > Hi Greg, > > What about enabling mips mt7621/arm mt7623 code at compile time? > Same binary can't be used on both platforms so it saves some space. > This also solved/eliminates the need for CPU detection which was also > needed if we want to support trgmii mode. > Device tree bindings are now similar between the two platforms, no extra > compatible id. That reduces compile coverage, that is not really the direction Linux drivers are going with in any case, even if some parts of the driver are only running in specific CPU/SoCs cases, we still want the driver to be as free as chip-specific or architecture specific knowledge. > > I think it should look something like this: > https://github.com/vDorst/linux-1/commit/93dc90ce56baeb3e71cae0f5339b811bbda57a97 > > > Greats, > > René > > > > > -- Florian