From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE22C04AA5 for ; Thu, 25 Aug 2022 11:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238408AbiHYLLo (ORCPT ); Thu, 25 Aug 2022 07:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235195AbiHYLLl (ORCPT ); Thu, 25 Aug 2022 07:11:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CEB49F0F9 for ; Thu, 25 Aug 2022 04:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661425899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q6R2kOFpSZu9B1r8tOPgQwwbnj/1FHfHwXqHb6Dl3U0=; b=VealhEOHfiAOIn/GfF+fTRSCbLPMW+jLw6ZUAwbEuAAV7xhI7Rwcnp9YruZnJXspxD2esF cyH3QRCUEfaplonhaEss4DXSzNHKLYLsXJigkfpdhEpAo2moFGDLXL4gRzoweh0nGV4O1/ CnRfoz8FmMiMWEFkNfjhHZ3+ugks4ds= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-527-Z7s8FkeyM0ONKvrA_2oHmA-1; Thu, 25 Aug 2022 07:11:38 -0400 X-MC-Unique: Z7s8FkeyM0ONKvrA_2oHmA-1 Received: by mail-wm1-f72.google.com with SMTP id v64-20020a1cac43000000b003a4bea31b4dso2328955wme.3 for ; Thu, 25 Aug 2022 04:11:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=Q6R2kOFpSZu9B1r8tOPgQwwbnj/1FHfHwXqHb6Dl3U0=; b=dla0VNg4BDjCzgE1/kzN5Mu3Vk2pE5askpCVS43jBTWRhPD54Uk6xJoBd91KqJtl3N ybYAMeXGfyZziiIOyHye8Knwk3AKJWSh2TJJ46MZaBQrpZh6KnM7YYvN8POwGmmdVXw/ nl8dY4VBux5A4pD9WWbJwSbdM/J1+nEER84evRKulfXQ8p8lrX8A5JxiGUbTZa/j/ths xnWC8W/1WM0rxZQKbMYwXKakZqzpppCDDlV9o7SDIcgPnt8b4EP9IrNG8XzUn7f2N+bm cFG263cD23Xq9Qtj0aT0WkFpergso09fQHah5Rq25G6mLaPPaq4Niz8ATnXR/RTRX3GN 8SCQ== X-Gm-Message-State: ACgBeo2V0fSi4Y0Vw7r1hgukbwKojm8BC6jI8d5jeaDQ2pXuoTH1brCm Yz7JhhDYbsSmQ/EDj6Dx+0E+Du+M6FA+bvSCosykG7UNzO/4dB50Yoh42mDr3ATBTOsQuSuoZIC VmKyD1CwhoAZD40eK X-Received: by 2002:a05:600c:2114:b0:3a5:4f31:3063 with SMTP id u20-20020a05600c211400b003a54f313063mr8238479wml.50.1661425897100; Thu, 25 Aug 2022 04:11:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR7m/LFh6KSjkSq7Lqgq/TVqkGBP1qeEks7lCgy4C/9MLYkzDLRcCb5wnUXKkDz3PgYGt0jMPA== X-Received: by 2002:a05:600c:2114:b0:3a5:4f31:3063 with SMTP id u20-20020a05600c211400b003a54f313063mr8238453wml.50.1661425896852; Thu, 25 Aug 2022 04:11:36 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-97-176.dyn.eolo.it. [146.241.97.176]) by smtp.gmail.com with ESMTPSA id c3-20020a7bc843000000b003a32297598csm4817740wml.43.2022.08.25.04.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 04:11:36 -0700 (PDT) Message-ID: <200cb2f98ca159003ed4deb51163e5f8859d4f8b.camel@redhat.com> Subject: Re: [PATCH net-next 1/3] net: prestera: acl: extract matchall logic into a separate file From: Paolo Abeni To: Maksym Glubokiy , Taras Chornyi , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: Serhiy Boiko , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Thu, 25 Aug 2022 13:11:35 +0200 In-Reply-To: <20220823113958.2061401-2-maksym.glubokiy@plvision.eu> References: <20220823113958.2061401-1-maksym.glubokiy@plvision.eu> <20220823113958.2061401-2-maksym.glubokiy@plvision.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, On Tue, 2022-08-23 at 14:39 +0300, Maksym Glubokiy wrote: > From: Serhiy Boiko > > This commit adds more clarity to handling of TC_CLSMATCHALL_REPLACE and > TC_CLSMATCHALL_DESTROY events by calling newly added *_mall_*() handlers > instead of directly calling SPAN API. > > This also extracts matchall rules management out of SPAN API since SPAN > is a hardware module which is used to implement 'matchall egress mirred' > action only. > > Signed-off-by: Taras Chornyi > Signed-off-by: Serhiy Boiko > Signed-off-by: Maksym Glubokiy This SoB chain is not clear to me. Did Taras co-developed the patch? In that case a Co-developed-by: tag is missing, as the first tag in the list. Otherwise why is Taras' SoB there? Thanks! Paolo