* [PATCH] iproute2: avoid using bashisms in configure script.
@ 2010-01-01 22:20 Andreas Henriksson
2010-01-21 18:09 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Henriksson @ 2010-01-01 22:20 UTC (permalink / raw)
To: shemminger; +Cc: netdev
"function foo" should be "foo()" to work when sh is not bash.
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
Sorry for not getting this right the first time around....
--- a/configure
+++ b/configure
@@ -3,7 +3,7 @@
#
INCLUDE=${1:-"$PWD/include"}
-function check_atm
+check_atm()
{
cat >/tmp/atmtest.c <<EOF
#include <atm.h>
@@ -24,7 +24,7 @@ fi
rm -f /tmp/atmtest.c /tmp/atmtest
}
-function check_xt
+check_xt()
{
#check if we have xtables from iptables >= 1.4.5.
cat >/tmp/ipttest.c <<EOF
@@ -55,7 +55,7 @@ fi
rm -f /tmp/ipttest.c /tmp/ipttest
}
-function check_xt_old
+check_xt_old()
{
# bail if previous XT checks has already succeded.
if grep TC_CONFIG_XT Config > /dev/null
@@ -94,7 +94,7 @@ fi
rm -f /tmp/ipttest.c /tmp/ipttest
}
-function check_xt_old_internal_h
+check_xt_old_internal_h()
{
# bail if previous XT checks has already succeded.
if grep TC_CONFIG_XT Config > /dev/null
@@ -134,7 +134,7 @@ fi
rm -f /tmp/ipttest.c /tmp/ipttest
}
-function check_ipt
+check_ipt()
{
if ! grep TC_CONFIG_XT Config > /dev/null
then
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iproute2: avoid using bashisms in configure script.
2010-01-01 22:20 [PATCH] iproute2: avoid using bashisms in configure script Andreas Henriksson
@ 2010-01-21 18:09 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2010-01-21 18:09 UTC (permalink / raw)
To: Andreas Henriksson; +Cc: netdev
On Fri, 1 Jan 2010 23:20:30 +0100
Andreas Henriksson <andreas@fatal.se> wrote:
> "function foo" should be "foo()" to work when sh is not bash.
>
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
> ---
applied,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-21 18:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-01 22:20 [PATCH] iproute2: avoid using bashisms in configure script Andreas Henriksson
2010-01-21 18:09 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).