* [patch 1/1] net/sctp/socket.c: squish warning
@ 2009-12-22 0:25 akpm
2010-01-04 5:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2009-12-22 0:25 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, andrei, vladislav.yasevich
From: Andrew Morton <akpm@linux-foundation.org>
net/sctp/socket.c: In function 'sctp_setsockopt_autoclose':
net/sctp/socket.c:2090: warning: comparison is always false due to limited range of data type
Cc: Andrei Pelinescu-Onciul <andrei@iptel.org>
Cc: Vlad Yasevich <vladislav.yasevich@hp.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
net/sctp/socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN net/sctp/socket.c~net-sctp-socketc-squish-warning net/sctp/socket.c
--- a/net/sctp/socket.c~net-sctp-socketc-squish-warning
+++ a/net/sctp/socket.c
@@ -2087,8 +2087,7 @@ static int sctp_setsockopt_autoclose(str
if (copy_from_user(&sp->autoclose, optval, optlen))
return -EFAULT;
/* make sure it won't exceed MAX_SCHEDULE_TIMEOUT */
- if (sp->autoclose > (MAX_SCHEDULE_TIMEOUT / HZ) )
- sp->autoclose = (__u32)(MAX_SCHEDULE_TIMEOUT / HZ) ;
+ sp->autoclose = min_t(long, sp->autoclose, MAX_SCHEDULE_TIMEOUT / HZ);
return 0;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] net/sctp/socket.c: squish warning
2009-12-22 0:25 [patch 1/1] net/sctp/socket.c: squish warning akpm
@ 2010-01-04 5:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-04 5:26 UTC (permalink / raw)
To: akpm; +Cc: netdev, andrei, vladislav.yasevich
From: akpm@linux-foundation.org
Date: Mon, 21 Dec 2009 16:25:06 -0800
> From: Andrew Morton <akpm@linux-foundation.org>
>
> net/sctp/socket.c: In function 'sctp_setsockopt_autoclose':
> net/sctp/socket.c:2090: warning: comparison is always false due to limited range of data type
>
> Cc: Andrei Pelinescu-Onciul <andrei@iptel.org>
> Cc: Vlad Yasevich <vladislav.yasevich@hp.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-04 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-22 0:25 [patch 1/1] net/sctp/socket.c: squish warning akpm
2010-01-04 5:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).