From: David Miller <davem@davemloft.net>
To: venza@brownhat.org
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, erik.andren@gmail.com
Subject: Re: [PATCH] sis900: print warning if MAC address is not available
Date: Sun, 03 Jan 2010 21:57:27 -0800 (PST) [thread overview]
Message-ID: <20100103.215727.177625500.davem@davemloft.net> (raw)
In-Reply-To: <20091230182243.GA26340@milesteg.arr>
From: Daniele Venzano <venza@brownhat.org>
Date: Wed, 30 Dec 2009 19:22:43 +0100
> The attached patch prints a warning if the MAC address is all 0s in the
> sis900 driver.
>
> The patch prints a warning whenever the MAC address read from the
> hardware is composed of all zeros.
> If the address cannot be read at all for some reason, the driver is
> already doing the right thing and bails out.
> In reference to bug 11649 from bugzilla.
>
> Please test this patch, it is trivial, but I only test-compiled it since
> I no longer have the hardware.
>
> Signed-off-by: Daniele Venzano <linux@brownhat.org>
We have a way to check for a valid mac address: is_valid_ether_addr()
Please use it instead of your home-grown function.
next prev parent reply other threads:[~2010-01-04 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 18:22 [PATCH] sis900: print warning if MAC address is not available Daniele Venzano
2010-01-04 5:57 ` David Miller [this message]
2010-01-04 19:08 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100103.215727.177625500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=erik.andren@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=venza@brownhat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).