netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: opurdila@ixiacom.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH] ip: fix mc_loop checks for tunnels with multicast outer addresses
Date: Sun, 03 Jan 2010 21:58:55 -0800 (PST)	[thread overview]
Message-ID: <20100103.215855.267134875.davem@davemloft.net> (raw)
In-Reply-To: <200912302201.37735.opurdila@ixiacom.com>

From: Octavian Purdila <opurdila@ixiacom.com>
Date: Wed, 30 Dec 2009 22:01:37 +0200

> +	switch (sk->sk_family) {
> +	case AF_INET:
> +		return inet_sk(sk)->mc_loop;
> +#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
> +	case AF_INET6:
> +		return inet6_sk(sk)->mc_loop;
> +	}
> +#endif
> +	__WARN();
> +	return 1;
> +}
> +

This won't compile with IPV6 disabled.  Switch closing brace is
erroneously inside of the ifdef test.


  reply	other threads:[~2010-01-04  5:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-30 20:01 [net-next PATCH] ip: fix mc_loop checks for tunnels with multicast outer addresses Octavian Purdila
2010-01-04  5:58 ` David Miller [this message]
2010-01-04 10:48   ` Octavian Purdila
2010-01-07  4:37     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100103.215855.267134875.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=opurdila@ixiacom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).