[PATCH] tcp: for tcp westwood implementation

[PATCH] tcp: for tcp westwood implementation

[Hwang Jae-Hyun]

From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>

Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with
Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected,
it is more natural that the interface points to 'tcp_westwood_bw_rttmin'
function, not Reno's function.
This patch also enables Westwood to perform its algorithm when CA_EVENT_LOSS
event is generated as explained in the papers.

Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
---

--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c      2009-12-28
13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
                westwood_fast_bw(sk);
                break;
 
-       case CA_EVENT_COMPLETE_CWR:
-               tp->snd_cwnd = tp->snd_ssthresh =
tcp_westwood_bw_rttmin(sk);
-               break;
-
        case CA_EVENT_FRTO:
-               tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
                /* Update RTT_min when next ack arrives */
                w->reset_rtt_min = 1;
                break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
 
 static struct tcp_congestion_ops tcp_westwood = {
        .init           = tcp_westwood_init,
-       .ssthresh       = tcp_reno_ssthresh,
+       .ssthresh       = tcp_westwood_bw_rttmin,
        .cong_avoid     = tcp_reno_cong_avoid,
-       .min_cwnd       = tcp_westwood_bw_rttmin,
        .cwnd_event     = tcp_westwood_event,
        .get_info       = tcp_westwood_info,
        .pkts_acked     = tcp_westwood_pkts_acked,
--

Re: [PATCH] tcp: for tcp westwood implementation

[David Miller]

Annyoung-haseyo,

Your patch was damaged by your email client (long lines
were chopped up with newlines, etc.), as such it is not
usable.

Please fix this up and resubmit your patch.

Re: [PATCH] tcp: for tcp westwood implementation

[Jae-Hyun Hwang]

I'm sorry about posting such a damaged email.
I resubmit the patch by plain-text.

From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>

Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected, it is more natural that the interface points to
'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when
CA_EVENT_LOSS event is generated as explained in the papers.

Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
---

--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c      2009-12-28
13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
                westwood_fast_bw(sk);
                break;

-       case CA_EVENT_COMPLETE_CWR:
-               tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
-               break;
-
        case CA_EVENT_FRTO:
-               tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
                /* Update RTT_min when next ack arrives */
                w->reset_rtt_min = 1;
                break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc

 static struct tcp_congestion_ops tcp_westwood = {
        .init           = tcp_westwood_init,
-       .ssthresh       = tcp_reno_ssthresh,
+       .ssthresh       = tcp_westwood_bw_rttmin,
        .cong_avoid     = tcp_reno_cong_avoid,
-       .min_cwnd       = tcp_westwood_bw_rttmin,
        .cwnd_event     = tcp_westwood_event,
        .get_info       = tcp_westwood_info,
        .pkts_acked     = tcp_westwood_pkts_acked,
--

On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
>
- Hide quoted text -
> Annyoung-haseyo,
>
> Your patch was damaged by your email client (long lines
> were chopped up with newlines, etc.), as such it is not
> usable.
>
> Please fix this up and resubmit your patch.
>

Re: [PATCH] tcp: for tcp westwood implementation

[Jarek Poplawski]

On 28-12-2009 07:35, Jae-Hyun Hwang wrote:
> I'm sorry about posting such a damaged email.
> I resubmit the patch by plain-text.

Most probably it's still wrong (e.g. no tabs).
http://marc.info/?l=linux-netdev&m=126198215600946&q=raw

Did you try to send it to yourself?

Jarek P.

> 
> From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
> 
> Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
> with Westwood papers.
> Since Linux TCP calls '.ssthresh' interface whenever packet loss is
> detected, it is more natural that the interface points to
> 'tcp_westwood_bw_rttmin' function, not Reno's function.
> This patch also enables Westwood to perform its algorithm when
> CA_EVENT_LOSS event is generated as explained in the papers.
> 
> Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
> ---
> 
> --- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28
> 13:35:42.000000000 +0900
> +++ linux-2.6.32.2/net/ipv4/tcp_westwood.c      2009-12-28
> 13:36:54.000000000 +0900
> @@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
>                 westwood_fast_bw(sk);
>                 break;
> 
> -       case CA_EVENT_COMPLETE_CWR:
> -               tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> -               break;
> -
>         case CA_EVENT_FRTO:
> -               tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
>                 /* Update RTT_min when next ack arrives */
>                 w->reset_rtt_min = 1;
>                 break;
> @@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
> 
>  static struct tcp_congestion_ops tcp_westwood = {
>         .init           = tcp_westwood_init,
> -       .ssthresh       = tcp_reno_ssthresh,
> +       .ssthresh       = tcp_westwood_bw_rttmin,
>         .cong_avoid     = tcp_reno_cong_avoid,
> -       .min_cwnd       = tcp_westwood_bw_rttmin,
>         .cwnd_event     = tcp_westwood_event,
>         .get_info       = tcp_westwood_info,
>         .pkts_acked     = tcp_westwood_pkts_acked,
> --
> 
> On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
> - Hide quoted text -
>> Annyoung-haseyo,
>>
>> Your patch was damaged by your email client (long lines
>> were chopped up with newlines, etc.), as such it is not
>> usable.
>>
>> Please fix this up and resubmit your patch.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] tcp: for tcp westwood implementation

[Jae-Hyun Hwang]

Is it still wrong?
I hope this patch is successful.

From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>

Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected, it is more natural that the interface points to
'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when
CA_EVENT_LOSS event is generated as explained in the papers.

Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>

---

--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig	2009-12-28
13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c	2009-12-28 13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
 		westwood_fast_bw(sk);
 		break;

-	case CA_EVENT_COMPLETE_CWR:
-		tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
-		break;
-
 	case CA_EVENT_FRTO:
-		tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
 		/* Update RTT_min when next ack arrives */
 		w->reset_rtt_min = 1;
 		break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc

 static struct tcp_congestion_ops tcp_westwood = {
 	.init		= tcp_westwood_init,
-	.ssthresh	= tcp_reno_ssthresh,
+	.ssthresh	= tcp_westwood_bw_rttmin,
 	.cong_avoid	= tcp_reno_cong_avoid,
-	.min_cwnd	= tcp_westwood_bw_rttmin,
 	.cwnd_event	= tcp_westwood_event,
 	.get_info	= tcp_westwood_info,
 	.pkts_acked	= tcp_westwood_pkts_acked,
--



On Mon, Dec 28, 2009 at 5:43 PM, Jarek Poplawski <jarkao2@gmail.com> wrote:
> On 28-12-2009 07:35, Jae-Hyun Hwang wrote:
>> I'm sorry about posting such a damaged email.
>> I resubmit the patch by plain-text.
>
> Most probably it's still wrong (e.g. no tabs).
> http://marc.info/?l=linux-netdev&m=126198215600946&q=raw
>
> Did you try to send it to yourself?
>
> Jarek P.
>
>>
>> On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
>> - Hide quoted text -
>>> Annyoung-haseyo,
>>>
>>> Your patch was damaged by your email client (long lines
>>> were chopped up with newlines, etc.), as such it is not
>>> usable.
>>>
>>> Please fix this up and resubmit your patch.
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
>
>
>

Re: [PATCH] tcp: for tcp westwood implementation

[Jarek Poplawski]

On Mon, Dec 28, 2009 at 07:52:23PM +0900, Jae-Hyun Hwang wrote:
> Is it still wrong?
> I hope this patch is successful.

I hope too, but it depends on David. This time it's mostly OK, execept
"Content-Transfer-Encoding: quoted-printable" instead of "inline", as
required by Documentation/SubmittingPatches.

Jarek P.

PS: Btw, don't leave old information after the patch (next time).

> 
> From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
> 
> Current net/ipv4/tcp_westwood.c seems to be unnatural when compared
> with Westwood papers.
> Since Linux TCP calls '.ssthresh' interface whenever packet loss is
> detected, it is more natural that the interface points to
> 'tcp_westwood_bw_rttmin' function, not Reno's function.
> This patch also enables Westwood to perform its algorithm when
> CA_EVENT_LOSS event is generated as explained in the papers.
> 
> Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
> 
> ---
> 
> --- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig	2009-12-28
> 13:35:42.000000000 +0900
> +++ linux-2.6.32.2/net/ipv4/tcp_westwood.c	2009-12-28 13:36:54.000000000 +0900
> @@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
>  		westwood_fast_bw(sk);
>  		break;
> 
> -	case CA_EVENT_COMPLETE_CWR:
> -		tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
> -		break;
> -
>  	case CA_EVENT_FRTO:
> -		tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
>  		/* Update RTT_min when next ack arrives */
>  		w->reset_rtt_min = 1;
>  		break;
> @@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
> 
>  static struct tcp_congestion_ops tcp_westwood = {
>  	.init		= tcp_westwood_init,
> -	.ssthresh	= tcp_reno_ssthresh,
> +	.ssthresh	= tcp_westwood_bw_rttmin,
>  	.cong_avoid	= tcp_reno_cong_avoid,
> -	.min_cwnd	= tcp_westwood_bw_rttmin,
>  	.cwnd_event	= tcp_westwood_event,
>  	.get_info	= tcp_westwood_info,
>  	.pkts_acked	= tcp_westwood_pkts_acked,
> --
> 
> 
> 
> On Mon, Dec 28, 2009 at 5:43 PM, Jarek Poplawski <jarkao2@gmail.com> wrote:
> > On 28-12-2009 07:35, Jae-Hyun Hwang wrote:
> >> I'm sorry about posting such a damaged email.
> >> I resubmit the patch by plain-text.
> >
> > Most probably it's still wrong (e.g. no tabs).
> > http://marc.info/?l=linux-netdev&m=126198215600946&q=raw
> >
> > Did you try to send it to yourself?
> >
> > Jarek P.
> >
> >>
> >> On Mon, Dec 28, 2009 at 2:56 PM, David Miller <davem@davemloft.net> wrote:
> >> - Hide quoted text -
> >>> Annyoung-haseyo,
> >>>
> >>> Your patch was damaged by your email client (long lines
> >>> were chopped up with newlines, etc.), as such it is not
> >>> usable.
> >>>
> >>> Please fix this up and resubmit your patch.
> >>>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe netdev" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>
> >
> >
> >
> >

Re: [PATCH] tcp: for tcp westwood implementation

[David Miller]

From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 28 Dec 2009 12:32:02 +0000

> On Mon, Dec 28, 2009 at 07:52:23PM +0900, Jae-Hyun Hwang wrote:
>> Is it still wrong?
>> I hope this patch is successful.
> 
> I hope too, but it depends on David. This time it's mostly OK, execept
> "Content-Transfer-Encoding: quoted-printable" instead of "inline", as
> required by Documentation/SubmittingPatches.

Patchwork didn't pick it up either, it definitely needs to be
resent.