netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Mike McLagan <mike.mclagan@linux.org>
Cc: netdev@vger.kernel.org
Subject: off by one in sdla_close()
Date: Sun, 3 Jan 2010 12:04:05 +0200	[thread overview]
Message-ID: <20100103100405.GC13263@bicker> (raw)

drivers/net/wan/sdla.c
   955                  for(i=0;i<CONFIG_DLCI_MAX;i++)
   956                          if (flp->dlci[i] > 0)
   957                                  sdla_cmd(dev, SDLA_DEACTIVATE_DLCI, 0, 0, dlcis, len, NULL, NULL);
   958                  sdla_cmd(dev, SDLA_DELETE_DLCI, 0, 0, &flp->dlci[i], sizeof(flp->dlci[i]), NULL, NULL);
 
At the end of the for loop i == CONFIG_DLCI_MAX which is too high.

regards,
dan carpenter

                 reply	other threads:[~2010-01-03 10:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100103100405.GC13263@bicker \
    --to=error27@gmail.com \
    --cc=mike.mclagan@linux.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).