netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rakesh@chelsio.com
Cc: michaelc@cs.wisc.edu, open-iscsi@googlegroups.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	James.Bottomley@suse.de, kxie@chelsio.com
Subject: Re: [RFC-PATCH] libiscsi dhcp handler
Date: Mon, 04 Jan 2010 22:42:18 -0800 (PST)	[thread overview]
Message-ID: <20100104.224218.35346973.davem@davemloft.net> (raw)
In-Reply-To: <4B01577E.2020003@chelsio.com>

From: Rakesh Ranjan <rakesh@chelsio.com>
Date: Mon, 16 Nov 2009 19:15:34 +0530

> +	/* Construct UDP header */
> +	udph = &pkt->udph;
> +	udph->source = htons(DHCPC_CLIENT_PORT);
> +	udph->dest = htons(DHCPC_SERVER_PORT);
> +	udph->len = htons(sizeof(struct dhcp_pkt) - sizeof(struct iphdr));

UDP checksum is not set, and is also not validated on receive.

      parent reply	other threads:[~2010-01-05  6:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 13:11 [RFC-PATCH] libiscsi dhcp handler Rakesh Ranjan
2009-11-16 13:18 ` David Miller
2009-11-16 13:24   ` Rakesh Ranjan
2009-11-16 13:45   ` Rakesh Ranjan
     [not found]     ` <4B01577E.2020003-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2009-11-18  3:26       ` Rakesh Ranjan
2009-11-18  7:25         ` David Miller
2009-11-20 13:29     ` Dan Carpenter
2009-11-21  8:13       ` Dan Carpenter
2010-01-05  6:42     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100104.224218.35346973.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=James.Bottomley@suse.de \
    --cc=kxie@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=netdev@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    --cc=rakesh@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).