* [PATCH] tcp: for tcp westwood
@ 2010-01-04 8:18 Jae-Hyun Hwang
2010-01-04 16:43 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Jae-Hyun Hwang @ 2010-01-04 8:18 UTC (permalink / raw)
To: netdev
From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is
detected, it is more natural that the interface points to 'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when CA_EVENT_LOSS event is generated as explained in the papers.
Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28 13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28 13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
westwood_fast_bw(sk);
break;
- case CA_EVENT_COMPLETE_CWR:
- tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
- break;
-
case CA_EVENT_FRTO:
- tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
/* Update RTT_min when next ack arrives */
w->reset_rtt_min = 1;
break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
static struct tcp_congestion_ops tcp_westwood = {
.init = tcp_westwood_init,
- .ssthresh = tcp_reno_ssthresh,
+ .ssthresh = tcp_westwood_bw_rttmin,
.cong_avoid = tcp_reno_cong_avoid,
- .min_cwnd = tcp_westwood_bw_rttmin,
.cwnd_event = tcp_westwood_event,
.get_info = tcp_westwood_info,
.pkts_acked = tcp_westwood_pkts_acked,
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tcp: for tcp westwood
2010-01-04 8:18 [PATCH] tcp: for tcp westwood Jae-Hyun Hwang
@ 2010-01-04 16:43 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2010-01-04 16:43 UTC (permalink / raw)
To: Jae-Hyun Hwang; +Cc: netdev
On Mon, 4 Jan 2010 17:18:49 +0900
Jae-Hyun Hwang <jhhwang@os.korea.ac.kr> wrote:
> From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
>
> Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with Westwood papers.
The code was submitted after the original Westwood paper.
There were follow up papers, and the original author promised an update but it
never appeared.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-04 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-04 8:18 [PATCH] tcp: for tcp westwood Jae-Hyun Hwang
2010-01-04 16:43 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).