From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: Jan Ceuleers <jan.ceuleers@computer.org>
Cc: netdev@vger.kernel.org, "David Miller" <davem@davemloft.net>,
"Stéphane Berthelot" <sberthelot@emisfr.com>
Subject: Re: [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole
Date: Tue, 5 Jan 2010 07:28:00 +0100 [thread overview]
Message-ID: <20100105072800.13dba6d2@marrow.netinsight.se> (raw)
In-Reply-To: <4B423440.6060807@computer.org>
Hi,
Does the patch still work with the new NAPI support in the driver? Some
comments below:
On Mon, 04 Jan 2010 19:32:32 +0100
Jan Ceuleers <jan.ceuleers@computer.org> wrote:
> +static void velocity_poll_controller(struct net_device *dev)
> +{
> + disable_irq(dev->irq);
> + velocity_intr(dev->irq, dev);
> + enable_irq(dev->irq);
> +}
This should probably have an
#ifdef CONFIG_NET_POLL_CONTROLLER
...
#endif
around it since
> @@ -2628,6 +2642,9 @@ static const struct net_device_ops velocity_netdev_ops = {
> .ndo_vlan_rx_add_vid = velocity_vlan_rx_add_vid,
> .ndo_vlan_rx_kill_vid = velocity_vlan_rx_kill_vid,
> .ndo_vlan_rx_register = velocity_vlan_rx_register,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> + .ndo_poll_controller = velocity_poll_controller,
> +#endif
This one has it (to avoid a warning when building without it).
// Simon
next prev parent reply other threads:[~2010-01-05 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 18:32 [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole Jan Ceuleers
2010-01-05 6:28 ` Simon Kagstrom [this message]
2010-01-05 20:19 ` Jan Ceuleers
2010-01-07 6:26 ` Simon Kagstrom
2010-01-10 9:06 ` Jan Ceuleers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105072800.13dba6d2@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=davem@davemloft.net \
--cc=jan.ceuleers@computer.org \
--cc=netdev@vger.kernel.org \
--cc=sberthelot@emisfr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).