From: Stephen Hemminger <shemminger@vyatta.com>
To: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, dhananjay.phadke@qlogic.com
Subject: Re: [PATCH NEXT 2/2] qlcnic: Qlogic ethernet driver for CNA devices
Date: Tue, 5 Jan 2010 09:12:16 -0800 [thread overview]
Message-ID: <20100105091216.09cf4d17@nehalam> (raw)
In-Reply-To: <1262697876-26206-3-git-send-email-amit.salecha@qlogic.com>
One valid complaint from checkpatch:
ERROR: Macros with complex values should be enclosed in parenthesis
#2096: FILE: drivers/net/qlcnic/qlcnic_ethtool.c:41:
+#define QLCNIC_STAT(m) sizeof(((struct qlcnic_adapter *)0)->m), \
+ offsetof(struct qlcnic_adapter, m)
total: 1 errors, 0 warnings, 9611 lines checked
next prev parent reply other threads:[~2010-01-05 17:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 13:24 [PATCH NEXT 0/2] qlcnic: Add Qlogic 1/10Gb Ethernet driver for CNA devices Amit Kumar Salecha
2010-01-05 13:24 ` [PATCH NEXT 1/2] NET: Add Ethernet driver for QLOGIC " Amit Kumar Salecha
2010-01-05 13:24 ` [PATCH NEXT 2/2] qlcnic: Qlogic ethernet driver for " Amit Kumar Salecha
2010-01-05 17:08 ` Stephen Hemminger
2010-01-05 17:12 ` Stephen Hemminger [this message]
2010-01-05 17:07 ` [PATCH NEXT 0/2] qlcnic: Add Qlogic 1/10Gb Ethernet " Stephen Hemminger
2010-01-05 20:39 ` David Miller
2010-01-06 2:24 ` Amit Salecha
2010-01-06 2:36 ` Stephen Hemminger
2010-01-06 3:53 ` David Miller
2010-01-05 17:15 ` Stephen Hemminger
2010-01-05 18:40 ` Dhananjay Phadke
2010-01-05 18:45 ` Stephen Hemminger
2010-01-05 19:02 ` Dhananjay Phadke
2010-01-05 20:38 ` David Miller
2010-01-05 22:01 ` Dhananjay Phadke
2010-01-05 23:49 ` David Miller
2010-01-05 23:55 ` Dhananjay Phadke
2010-01-06 0:33 ` David Miller
2010-01-06 1:33 ` Rick Jones
2010-01-06 3:57 ` David Miller
2010-01-06 1:56 ` Dhananjay Phadke
2010-01-06 3:51 ` David Miller
2010-01-06 4:27 ` Dhananjay Phadke
2010-01-06 4:40 ` David Miller
2010-01-06 2:19 ` Dhananjay Phadke
2010-01-05 23:43 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105091216.09cf4d17@nehalam \
--to=shemminger@vyatta.com \
--cc=amit.salecha@qlogic.com \
--cc=davem@davemloft.net \
--cc=dhananjay.phadke@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).