From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: cfriesen@nortel.com, eric.dumazet@gmail.com,
nhorman@tuxdriver.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: packet: option to only pass skb protocol
Date: Tue, 5 Jan 2010 23:45:24 +0200 [thread overview]
Message-ID: <20100105214524.GA31301@redhat.com> (raw)
In-Reply-To: <20100105.134218.258781374.davem@davemloft.net>
On Tue, Jan 05, 2010 at 01:42:18PM -0800, David Miller wrote:
> From: "Chris Friesen" <cfriesen@nortel.com>
> Date: Tue, 05 Jan 2010 15:28:22 -0600
>
> > On 01/05/2010 12:57 PM, Michael S. Tsirkin wrote:
> >> When sending packets with a packet socket it is often necessary to set
> >> protocol in msg_name: otherwise the protocol field in the skb will not
> >> be set correctly.
> >
> > What about automatically detecting the protocol from the data being sent
> > to avoid the necessity of specifying it in the first place?
>
> This limits packet socket usage to only protocols the kernel is aware
> of, defeating part of the usefulness of the packet socket facility.
We could do this if the protocol is ETH_P_ALL - skbs end up with this
protocol currently when sendmsg does not have msgname and when socket is
set up to listen for all packets. It's not a valid protocol value, is
it?
--
MST
next prev parent reply other threads:[~2010-01-05 21:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 18:57 [PATCH] net: packet: option to only pass skb protocol Michael S. Tsirkin
2010-01-05 19:27 ` Eric Dumazet
2010-01-05 20:50 ` Michael S. Tsirkin
2010-01-05 21:40 ` David Miller
2010-01-05 21:50 ` Michael S. Tsirkin
2010-01-05 21:28 ` Chris Friesen
2010-01-05 21:42 ` David Miller
2010-01-05 21:45 ` Michael S. Tsirkin [this message]
2010-01-05 22:05 ` Michael S. Tsirkin
2010-01-05 22:13 ` Chris Friesen
2010-01-05 22:27 ` Michael S. Tsirkin
2010-01-05 23:51 ` David Miller
2010-01-06 9:12 ` Michael S. Tsirkin
2010-01-06 19:24 ` Michael S. Tsirkin
2010-01-07 8:27 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105214524.GA31301@redhat.com \
--to=mst@redhat.com \
--cc=cfriesen@nortel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).