netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ddaney@caviumnetworks.com
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
	netdev@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH 2/3] Staging: Octeon Ethernet: Clean up and convert to NAPI.
Date: Wed, 06 Jan 2010 17:01:38 -0800 (PST)	[thread overview]
Message-ID: <20100106.170138.71108684.davem@davemloft.net> (raw)
In-Reply-To: <1262825836-9457-2-git-send-email-ddaney@caviumnetworks.com>

From: David Daney <ddaney@caviumnetworks.com>
Date: Wed,  6 Jan 2010 16:57:15 -0800

> Convert the driver to be a reasonably well behaved NAPI citizen.  Also
> clean up memory allocation and tx buffer accounding code.  Remove some
> configuration #defines and other unused code that are not applicable
> to the in-tree driver.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>

Please seperate the cleanups and conversion to NAPI into seperate
patches.

Doing both at the same time makes your patch impossible to review.

  reply	other threads:[~2010-01-07  1:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07  0:55 [PATCH 0/3] Staging: Improvments to Octeon Ethernet driver David Daney
2010-01-07  0:57 ` [PATCH 1/3] MIPS: Octeon: Fix EIO handling David Daney
2010-01-07  0:57 ` [PATCH 2/3] Staging: Octeon Ethernet: Clean up and convert to NAPI David Daney
2010-01-07  1:01   ` David Miller [this message]
2010-01-07  0:57 ` [PATCH 3/3] Staging: Octeon Ethernet: Enable scatter-gather David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100106.170138.71108684.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ddaney@caviumnetworks.com \
    --cc=gregkh@suse.de \
    --cc=linux-mips@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).