netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Cc: nhorman@tuxdriver.com, ilpo.jarvinen@helsinki.fi
Subject: Re: BSD 4.2 style TCP keepalives
Date: Wed, 06 Jan 2010 19:36:08 -0800 (PST)	[thread overview]
Message-ID: <20100106.193608.193693425.davem@davemloft.net> (raw)
In-Reply-To: <20100106.192131.193700514.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 06 Jan 2010 19:21:31 -0800 (PST)

> And maybe that's a clue, because with this upstream Linux does ACK the
> probe.

Here's an example trace, note the DSACK blocks:

19:26:51.966289 IP A.34376 > B.330: . ack 22738433 win 0 <nop,nop,timestamp 4294964458 375470>
19:26:52.185946 IP B.330 > A.34376: . 22738432:22738433(1) ack 10753 win 127 <nop,nop,timestamp 375492 4294964458>
19:26:52.207848 IP A.34376 > B.330: . ack 22738433 win 0 <nop,nop,timestamp 4294964480 375492,nop,nop,sack 1 {22738432:22738433}>
19:26:52.645946 IP B.330 > A.34376: . 22738432:22738433(1) ack 10753 win 127 <nop,nop,timestamp 375538 4294964480>
19:26:52.668386 IP A.34376 > B.330: . ack 22738433 win 0 <nop,nop,timestamp 4294964526 375538,nop,nop,sack 1 {22738432:22738433}>
19:26:53.545949 IP B.330 > A.34376: . 22738432:22738433(1) ack 10753 win 127 <nop,nop,timestamp 375628 4294964526>
19:26:53.568955 IP A.34376 > B.330: . ack 22738433 win 0 <nop,nop,timestamp 4294964616 375628,nop,nop,sack 1 {22738432:22738433}>
19:26:55.328448 IP B.330 > A.34376: . 22738432:22738433(1) ack 10753 win 127 <nop,nop,timestamp 375806 4294964616>
19:26:55.351998 IP A.34376 > B.330: . ack 22738433 win 0 <nop,nop,timestamp 4294964794 375806,nop,nop,sack 1 {22738432:22738433}>

I added diagnostics to tcp_data_queue() to validate which conditional
triggers:

[  662.808884] TCP: HIT SYN[0] FIN[0] ACK[1] SEQ[a018c50f:a018c510] rcv_nxt[a018c510] rcv_wup[a018c510] window[00000000]
[  662.822532] TCP: tcp_data_queue() !after(end_seq, rcv_nxt)

Which is what I said should trigger for these things.

  reply	other threads:[~2010-01-07  3:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06  0:39 BSD 4.2 style TCP keepalives David Miller
2010-01-06  2:07 ` Neil Horman
2010-01-06  3:59   ` David Miller
2010-01-06 17:21     ` Rick Jones
2010-01-06 20:50       ` Neil Horman
2010-01-06  8:23 ` David Miller
2010-01-06 23:04   ` David Miller
2010-01-07  0:14     ` David Miller
2010-01-07  3:21       ` David Miller
2010-01-07  3:36         ` David Miller [this message]
2010-01-07  0:34     ` Ilpo Järvinen
2010-01-07  0:59       ` David Miller
2010-01-07  7:55         ` Ilpo Järvinen
2010-01-08 12:40 ` Neil Horman
2010-01-08 21:21   ` David Miller
2010-01-09  1:22     ` Neil Horman
2010-01-09  1:41       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100106.193608.193693425.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).