[PATCH 5/6] hso: Fix for 5 sec timeouts with v2.x firmware

[PATCH 5/6] hso: Fix for 5 sec timeouts with v2.x firmware

[Jan Dumon]

From: Jan Dumon <j.dumon@option.com>

Don't send flow control settings to any port other than the modem port.
Older firmware ignored this request but did sent a reply. Newer firmware just
ignores it without reply and causes a 5 second timeout every time a port
(except for the modem port) is opened or if tiocm settings are changed.

Signed-off-by: Jan Dumon <j.dumon@option.com>

--- linux-2.6.orig/drivers/net/usb/hso.c
+++ linux-2.6/drivers/net/usb/hso.c
@@ -1723,6 +1723,10 @@ static int hso_serial_tiocmset(struct tt
 		D1("no tty structures");
 		return -EINVAL;
 	}
+
+	if ((serial->parent->port_spec & HSO_PORT_MASK) != HSO_PORT_MODEM)
+		return -EINVAL;
+
 	if_num = serial->parent->interface->altsetting->desc.bInterfaceNumber;
 
 	spin_lock_irqsave(&serial->serial_lock, flags);

Re: [PATCH 5/6] hso: Fix for 5 sec timeouts with v2.x firmware

[David Miller]

From: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Date: Tue, 5 Jan 2010 15:52:42 +0100

> From: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
> 
> Don't send flow control settings to any port other than the modem port.
> Older firmware ignored this request but did sent a reply. Newer firmware just
> ignores it without reply and causes a 5 second timeout every time a port
> (except for the modem port) is opened or if tiocm settings are changed.
> 
> Signed-off-by: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html