* [PATCH] cs89x0: Always report failure to request interrupt
@ 2010-01-05 11:16 Mark Brown
2010-01-07 8:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2010-01-05 11:16 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Mark Brown
A failure on request_irq() is always fatal but unlike other fatal
errors it's only reported to the user if net_debug is set. Make the
diagnostic unconditional and raise the priority so that errors are
more obvious to the user.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/net/cs89x0.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c
index 5598677..9b5bbc6 100644
--- a/drivers/net/cs89x0.c
+++ b/drivers/net/cs89x0.c
@@ -1325,8 +1325,7 @@ net_open(struct net_device *dev)
write_irq(dev, lp->chip_type, dev->irq);
ret = request_irq(dev->irq, net_interrupt, 0, dev->name, dev);
if (ret) {
- if (net_debug)
- printk(KERN_DEBUG "cs89x0: request_irq(%d) failed\n", dev->irq);
+ printk(KERN_ERR "cs89x0: request_irq(%d) failed\n", dev->irq);
goto bad_out;
}
}
--
1.6.5.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cs89x0: Always report failure to request interrupt
2010-01-05 11:16 [PATCH] cs89x0: Always report failure to request interrupt Mark Brown
@ 2010-01-07 8:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-07 8:53 UTC (permalink / raw)
To: broonie; +Cc: netdev
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Tue, 5 Jan 2010 11:16:50 +0000
> A failure on request_irq() is always fatal but unlike other fatal
> errors it's only reported to the user if net_debug is set. Make the
> diagnostic unconditional and raise the priority so that errors are
> more obvious to the user.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-07 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-05 11:16 [PATCH] cs89x0: Always report failure to request interrupt Mark Brown
2010-01-07 8:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).