From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hawk@comx.dk, netdev@vger.kernel.org
Subject: Re: [net-next PATCH] net: Make it easier to parse /proc/net/dev contents.
Date: Thu, 07 Jan 2010 00:59:29 -0800 (PST) [thread overview]
Message-ID: <20100107.005929.125556875.davem@davemloft.net> (raw)
In-Reply-To: <4B44263D.20604@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 06 Jan 2010 06:57:17 +0100
> Le 05/01/2010 16:50, Jesper Dangaard Brouer a écrit :
>> The contents of /proc/net/dev is annoying to parse, because
>> it changes whether there is a space after the "ethX:" or not.
>> It depends upon the size of the "Receive bytes" counter,
>> if the number is below 7 digits, then there is whitespaces
>> else if the number is 8 digits or above there is no space
>> between the ":" and the number.
>>
>> This patch changes the output to assure there is always a space
>> between the ":" and the number. Given that all existing userspace
>> application already need to handle the whitespaces, I see
>> no breakage of existing tools.
>>
>> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-01-07 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 15:50 [net-next PATCH] net: Make it easier to parse /proc/net/dev contents Jesper Dangaard Brouer
2010-01-06 5:57 ` Eric Dumazet
2010-01-07 8:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107.005929.125556875.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hawk@comx.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).