From: David Miller <davem@davemloft.net>
To: grundler@parisc-linux.org
Cc: ben@decadent.org.uk, brandon@ifup.org, grundler@google.com,
tobias@ringis.se, kyle@mcmartin.ca, netdev@vger.kernel.org
Subject: Re: [PATCH v2] dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips
Date: Thu, 07 Jan 2010 01:06:51 -0800 (PST) [thread overview]
Message-ID: <20100107.010651.18296756.davem@davemloft.net> (raw)
In-Reply-To: <20100107.005125.202622527.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 07 Jan 2010 00:51:25 -0800 (PST)
> From: Grant Grundler <grundler@parisc-linux.org>
> Date: Tue, 5 Jan 2010 09:58:17 -0700
>
>> On Tue, Jan 05, 2010 at 03:03:08AM +0000, Ben Hutchings wrote:
>>> The Davicom DM9100 and DM9102 chips are used on the motherboards of
>>> some SPARC systems (supported by the tulip driver) and also in PCI
>>> expansion cards (supported by the dmfe driver). There is no
>>> difference in the PCI device ids for the two different configurations,
>>> so these drivers both claim the device ids. However, it is possible
>>> to distinguish the two configurations by the presence of Open Firmware
>>> properties for them, so we do that.
>>>
>>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>>
>> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
>
> Applied, thanks everyone.
Sorry, had to revert, doesn't build:
CHK include/linux/version.h
CHK include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-sparc
CALL scripts/checksyscalls.sh
CC [M] drivers/net/tulip/dmfe.o
drivers/net/tulip/dmfe.c: In function 'dmfe_init_one':
drivers/net/tulip/dmfe.c:386: warning: suggest parentheses around && within ||
drivers/net/tulip/dmfe.c:389: error: implicit declaration of function 'of_get_property'
make[1]: *** [drivers/net/tulip/dmfe.o] Error 1
make: *** [drivers/net/tulip/dmfe.o] Error 2
Please fix this up and resubmit, thanks.
next prev parent reply other threads:[~2010-01-07 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 3:03 [PATCH v2] dmfe/tulip: Let dmfe handle DM910x except for SPARC on-board chips Ben Hutchings
2010-01-05 16:58 ` Grant Grundler
2010-01-07 8:51 ` David Miller
2010-01-07 9:06 ` David Miller [this message]
2010-01-07 12:41 ` [PATCH v3] " Ben Hutchings
2010-01-07 18:46 ` Grant Grundler
2010-01-08 1:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107.010651.18296756.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=brandon@ifup.org \
--cc=grundler@google.com \
--cc=grundler@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=netdev@vger.kernel.org \
--cc=tobias@ringis.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).