* [PATCH] drivers/firmware/iscsi_ibft.c: use %pM to show MAC address
@ 2010-01-05 16:37 H Hartley Sweeten
2010-01-07 9:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2010-01-05 16:37 UTC (permalink / raw)
To: Linux Kernel; +Cc: netdev, pjones, davem
Use the %pM kernel extension to display the MAC address.
Also, remove the 'mac' variable and use nic->mac directly.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Peter Jones <pjones@redhat.com>
Cc: David S. Miller <davem@davemloft.net>
---
Repost due to merge issues.
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 051d1eb..5aeb3b5 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -380,7 +380,6 @@ static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
struct ibft_nic *nic = entry->nic;
void *ibft_loc = entry->header;
char *str = buf;
- char *mac;
int val;
if (!nic)
@@ -421,10 +420,7 @@ static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
str += sprintf(str, "%d\n", nic->vlan);
break;
case ibft_eth_mac:
- mac = nic->mac;
- str += sprintf(str, "%02x:%02x:%02x:%02x:%02x:%02x\n",
- (u8)mac[0], (u8)mac[1], (u8)mac[2],
- (u8)mac[3], (u8)mac[4], (u8)mac[5]);
+ str += sprintf(str, "%pM\n", nic->mac);
break;
case ibft_eth_hostname:
str += sprintf_string(str, nic->hostname_len,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/firmware/iscsi_ibft.c: use %pM to show MAC address
2010-01-05 16:37 [PATCH] drivers/firmware/iscsi_ibft.c: use %pM to show MAC address H Hartley Sweeten
@ 2010-01-07 9:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-01-07 9:16 UTC (permalink / raw)
To: hartleys; +Cc: linux-kernel, netdev, pjones
From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 5 Jan 2010 09:37:43 -0700
> Use the %pM kernel extension to display the MAC address.
>
> Also, remove the 'mac' variable and use nic->mac directly.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Peter Jones <pjones@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-07 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-05 16:37 [PATCH] drivers/firmware/iscsi_ibft.c: use %pM to show MAC address H Hartley Sweeten
2010-01-07 9:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).