From: David Miller <davem@davemloft.net>
To: opurdila@ixiacom.com
Cc: netdev@vger.kernel.org, mpyatkovskiy@ixiacom.com
Subject: Re: [PATCH] tcp: account SYN-ACK timeouts & retransmissions
Date: Thu, 07 Jan 2010 17:25:07 -0800 (PST) [thread overview]
Message-ID: <20100107.172507.04893002.davem@davemloft.net> (raw)
In-Reply-To: <1262808658-29346-1-git-send-email-opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Wed, 6 Jan 2010 22:10:58 +0200
> Signed-off-by: Maksim Pyatkovskiy <mpyatkovskiy@ixiacom.com>
> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
RETRANSSEGS is meant to count data segments retransmits, not pure
control frames.
Similarly for TCPTIMEOUTS, it's mean for data retransmit timeouts.
If you overload these statistics with other similar events, they
become less meaningful.
Finally, bumping TCP specific statistics from the generic INET
connection oriented socket code is a huge no-no. That code is
written to be protocol agnostic.
next prev parent reply other threads:[~2010-01-08 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:10 [PATCH] tcp: account SYN-ACK timeouts & retransmissions Octavian Purdila
2010-01-08 1:25 ` David Miller [this message]
2010-01-11 22:16 ` Octavian Purdila
2010-01-12 0:15 ` David Miller
2010-01-12 16:55 ` Octavian Purdila
2010-01-13 21:07 ` Octavian Purdila
2010-01-14 10:03 ` David Miller
2010-01-17 19:27 ` Octavian Purdila
2010-01-18 3:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107.172507.04893002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mpyatkovskiy@ixiacom.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).