From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: jeff@garzik.org, joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net/: use DEFINE_PCI_DEVICE_TABLE()
Date: Thu, 07 Jan 2010 23:54:44 -0800 (PST) [thread overview]
Message-ID: <20100107.235444.238609921.davem@davemloft.net> (raw)
In-Reply-To: <20100108073447.GA4070@x200>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 8 Jan 2010 09:34:47 +0200
> On Thu, Jan 07, 2010 at 05:28:00PM -0500, Jeff Garzik wrote:
>> On 01/07/2010 05:25 PM, Joe Perches wrote:
>> > On Thu, 2010-01-07 at 23:58 +0200, Alexey Dobriyan wrote:
>> >> Use DEFINE_PCI_DEVICE_TABLE() so we get place PCI ids table into correct section
>> >> in every case.
>> >
>> > Good idea, but aren't there are some tables that are not const?
>>
>> I hope not... those tables are read by userland tools.
>
> I checked non-static ones, they are readonly.
> and PCI layer expects them to be readonly.
Great, patch applied, thanks!
prev parent reply other threads:[~2010-01-08 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 21:58 [PATCH] drivers/net/: use DEFINE_PCI_DEVICE_TABLE() Alexey Dobriyan
2010-01-07 22:25 ` Joe Perches
2010-01-07 22:28 ` Jeff Garzik
2010-01-08 7:34 ` Alexey Dobriyan
2010-01-08 7:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107.235444.238609921.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=jeff@garzik.org \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).