From: David Miller <davem@davemloft.net>
To: "kirjanov@gmail.com"@sunset.davemloft.net.davemloft.net,
kirjanov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] vxge: use pci_dma_mapping_error to test return value
Date: Fri, 08 Jan 2010 00:55:28 -0800 (PST) [thread overview]
Message-ID: <20100108.005528.263100819.davem@davemloft.net> (raw)
In-Reply-To: <20100105211659.GA12882@coldcone>
From: "Denis Kirjanov <kirjanov@gmail.com" <kirjanov@gmail.com>
Date: Wed, 6 Jan 2010 00:16:59 +0300
> @@ -821,7 +821,7 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
> int frg_cnt, first_frg_len;
> skb_frag_t *frag;
> int i = 0, j = 0, avail;
> - u64 dma_pointer;
> + dma_addr_t dma_pointer;
> struct vxge_tx_priv *txdl_priv = NULL;
> struct __vxge_hw_fifo *fifo_hw;
> int offload_type;
This will cause build warnings on platforms withe dma_addr_t
is some type other than "unsigned long long", such as on
sparc64 where it is a u32.
This is because of the %ll printf format used to display it
a few lines down from here.
next prev parent reply other threads:[~2010-01-08 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 21:16 [PATCH] vxge: use pci_dma_mapping_error to test return value Denis Kirjanov <kirjanov@gmail.com
2010-01-08 8:55 ` David Miller [this message]
2010-01-09 19:52 ` Denis Kirjanov <kirjanov@gmail.com
2010-01-10 21:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108.005528.263100819.davem@davemloft.net \
--to=davem@davemloft.net \
--cc="kirjanov@gmail.com"@sunset.davemloft.net.davemloft.net \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).